Re: [PATCH] reftable: make REFTABLE_UNUSED C99 compatible

From: Jeff King <peff@peff.net>
Date: May 30, 2025, 06:25 UTC
Message-ID: <20250530062533.GA1321283@coredump.intra.peff.net>
In-Reply-To: <aDlDtbUcX5NA8wCK@pks.im>

On Fri, May 30, 2025 at 07:35:49AM +0200, Patrick Steinhardt wrote:

> What I don't understand though: we have a `MAYBE_UNUSED` macro that has
> the exact same definition in "git-compat-util.h". Why does the macro
> cause issues in the reftable library, but not over there?

We turn __attribute__() into a noop for some platforms earlier in git-compat-util.h. So it doesn't need a separate #ifdef.

-Peff