[PATCH v2 03/10] t/unit-tests: convert reftable block test to use clar
- From
Seyi Kuforiji <kuforiji98@gmail.com>
- Date
- Apr 29, 2025, 17:52 UTC
- Message-ID
- <20250429175302.23724-4-kuforiji98@gmail.com>
- In-Reply-To
- <20250429175302.23724-1-kuforiji98@gmail.com>
Adapt reftable block test file to use clar testing framework by using clar assertions where necessary.
Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com> --- Makefile | 2 +- t/meson.build | 2 +- t/unit-tests/t-reftable-block.c | 383 -------------------------------- t/unit-tests/u-reftable-block.c | 373 +++++++++++++++++++++++++++++++ 4 files changed, 375 insertions(+), 385 deletions(-) delete mode 100644 t/unit-tests/t-reftable-block.c create mode 100644 t/unit-tests/u-reftable-block.c
diff --git a/Makefile b/Makefile index 7b12bb078c..239c575dad 100644 --- a/Makefile +++ b/Makefile @@ -1363,6 +1363,7 @@ CLAR_TEST_SUITES += u-oidmap CLAR_TEST_SUITES += u-oidtree CLAR_TEST_SUITES += u-prio-queue CLAR_TEST_SUITES += u-reftable-basics +CLAR_TEST_SUITES += u-reftable-block CLAR_TEST_SUITES += u-reftable-tree CLAR_TEST_SUITES += u-strbuf CLAR_TEST_SUITES += u-strcmp-offset @@ -1375,7 +1376,6 @@ CLAR_TEST_OBJS += $(UNIT_TEST_DIR)/clar/clar.o CLAR_TEST_OBJS += $(UNIT_TEST_DIR)/unit-test.o CLAR_TEST_OBJS += $(UNIT_TEST_DIR)/lib-oid.o -UNIT_TEST_PROGRAMS += t-reftable-block UNIT_TEST_PROGRAMS += t-reftable-merged UNIT_TEST_PROGRAMS += t-reftable-pq UNIT_TEST_PROGRAMS += t-reftable-reader diff --git a/t/meson.build b/t/meson.build index 8a42b595d9..e0d723e74b 100644 --- a/t/meson.build +++ b/t/meson.build @@ -9,6 +9,7 @@ clar_test_suites = [ 'unit-tests/u-oidtree.c', 'unit-tests/u-prio-queue.c', 'unit-tests/u-reftable-basics.c', + 'unit-tests/u-reftable-block.c', 'unit-tests/u-reftable-tree.c', 'unit-tests/u-strbuf.c', 'unit-tests/u-strcmp-offset.c', @@ -55,7 +56,6 @@ clar_unit_tests = executable('unit-tests', test('unit-tests', clar_unit_tests) unit_test_programs = [ - 'unit-tests/t-reftable-block.c', 'unit-tests/t-reftable-merged.c', 'unit-tests/t-reftable-pq.c', 'unit-tests/t-reftable-reader.c', diff --git a/t/unit-tests/t-reftable-block.c b/t/unit-tests/t-reftable-block.c deleted file mode 100644 index 22040aeefa..0000000000 --- a/t/unit-tests/t-reftable-block.c +++ /dev/null @@ -1,383 +0,0 @@ -/* -Copyright 2020 Google LLC - -Use of this source code is governed by a BSD-style -license that can be found in the LICENSE file or at -https://developers.google.com/open-source/licenses/bsd -*/ - -#include "test-lib.h" -#include "reftable/block.h" -#include "reftable/blocksource.h" -#include "reftable/constants.h" -#include "reftable/reftable-error.h" -#include "strbuf.h" - -static void t_ref_block_read_write(void) -{ - const int header_off = 21; /* random */ - struct reftable_record recs[30]; - const size_t N = ARRAY_SIZE(recs); - const size_t block_size = 1024; - struct reftable_block block = { 0 }; - struct block_writer bw = { - .last_key = REFTABLE_BUF_INIT, - }; - struct reftable_record rec = { - .type = BLOCK_TYPE_REF, - }; - size_t i = 0; - int ret; - struct block_reader br = { 0 }; - struct block_iter it = BLOCK_ITER_INIT; - struct reftable_buf want = REFTABLE_BUF_INIT, buf = REFTABLE_BUF_INIT; - - REFTABLE_CALLOC_ARRAY(block.data, block_size); - check(block.data != NULL); - block.len = block_size; - block_source_from_buf(&block.source ,&buf); - ret = block_writer_init(&bw, BLOCK_TYPE_REF, block.data, block_size, - header_off, hash_size(REFTABLE_HASH_SHA1)); - check(!ret); - - rec.u.ref.refname = (char *) ""; - rec.u.ref.value_type = REFTABLE_REF_DELETION; - ret = block_writer_add(&bw, &rec); - check_int(ret, ==, REFTABLE_API_ERROR); - - for (i = 0; i < N; i++) { - rec.u.ref.refname = xstrfmt("branch%02"PRIuMAX, (uintmax_t)i); - rec.u.ref.value_type = REFTABLE_REF_VAL1; - memset(rec.u.ref.value.val1, i, REFTABLE_HASH_SIZE_SHA1); - - recs[i] = rec; - ret = block_writer_add(&bw, &rec); - rec.u.ref.refname = NULL; - rec.u.ref.value_type = REFTABLE_REF_DELETION; - check_int(ret, ==, 0); - } - - ret = block_writer_finish(&bw); - check_int(ret, >, 0); - - block_writer_release(&bw); - - block_reader_init(&br, &block, header_off, block_size, REFTABLE_HASH_SIZE_SHA1); - - block_iter_seek_start(&it, &br); - - for (i = 0; ; i++) { - ret = block_iter_next(&it, &rec); - check_int(ret, >=, 0); - if (ret > 0) { - check_int(i, ==, N); - break; - } - check(reftable_record_equal(&recs[i], &rec, REFTABLE_HASH_SIZE_SHA1)); - } - - for (i = 0; i < N; i++) { - block_iter_reset(&it); - reftable_record_key(&recs[i], &want); - - ret = block_iter_seek_key(&it, &br, &want); - check_int(ret, ==, 0); - - ret = block_iter_next(&it, &rec); - check_int(ret, ==, 0); - - check(reftable_record_equal(&recs[i], &rec, REFTABLE_HASH_SIZE_SHA1)); - - want.len--; - ret = block_iter_seek_key(&it, &br, &want); - check_int(ret, ==, 0); - - ret = block_iter_next(&it, &rec); - check_int(ret, ==, 0); - check(reftable_record_equal(&recs[10 * (i / 10)], &rec, REFTABLE_HASH_SIZE_SHA1)); - } - - block_reader_release(&br); - block_iter_close(&it); - reftable_record_release(&rec); - reftable_block_done(&br.block); - reftable_buf_release(&want); - reftable_buf_release(&buf); - for (i = 0; i < N; i++) - reftable_record_release(&recs[i]); -} - -static void t_log_block_read_write(void) -{ - const int header_off = 21; - struct reftable_record recs[30]; - const size_t N = ARRAY_SIZE(recs); - const size_t block_size = 2048; - struct reftable_block block = { 0 }; - struct block_writer bw = { - .last_key = REFTABLE_BUF_INIT, - }; - struct reftable_record rec = { - .type = BLOCK_TYPE_LOG, - }; - size_t i = 0; - int ret; - struct block_reader br = { 0 }; - struct block_iter it = BLOCK_ITER_INIT; - struct reftable_buf want = REFTABLE_BUF_INIT, buf = REFTABLE_BUF_INIT; - - REFTABLE_CALLOC_ARRAY(block.data, block_size); - check(block.data != NULL); - block.len = block_size; - block_source_from_buf(&block.source ,&buf); - ret = block_writer_init(&bw, BLOCK_TYPE_LOG, block.data, block_size, - header_off, hash_size(REFTABLE_HASH_SHA1)); - check(!ret); - - for (i = 0; i < N; i++) { - rec.u.log.refname = xstrfmt("branch%02"PRIuMAX , (uintmax_t)i); - rec.u.log.update_index = i; - rec.u.log.value_type = REFTABLE_LOG_UPDATE; - - recs[i] = rec; - ret = block_writer_add(&bw, &rec); - rec.u.log.refname = NULL; - rec.u.log.value_type = REFTABLE_LOG_DELETION; - check_int(ret, ==, 0); - } - - ret = block_writer_finish(&bw); - check_int(ret, >, 0); - - block_writer_release(&bw); - - block_reader_init(&br, &block, header_off, block_size, REFTABLE_HASH_SIZE_SHA1); - - block_iter_seek_start(&it, &br); - - for (i = 0; ; i++) { - ret = block_iter_next(&it, &rec); - check_int(ret, >=, 0); - if (ret > 0) { - check_int(i, ==, N); - break; - } - check(reftable_record_equal(&recs[i], &rec, REFTABLE_HASH_SIZE_SHA1)); - } - - for (i = 0; i < N; i++) { - block_iter_reset(&it); - reftable_buf_reset(&want); - check(!reftable_buf_addstr(&want, recs[i].u.log.refname)); - - ret = block_iter_seek_key(&it, &br, &want); - check_int(ret, ==, 0); - - ret = block_iter_next(&it, &rec); - check_int(ret, ==, 0); - - check(reftable_record_equal(&recs[i], &rec, REFTABLE_HASH_SIZE_SHA1)); - - want.len--; - ret = block_iter_seek_key(&it, &br, &want); - check_int(ret, ==, 0); - - ret = block_iter_next(&it, &rec); - check_int(ret, ==, 0); - check(reftable_record_equal(&recs[10 * (i / 10)], &rec, REFTABLE_HASH_SIZE_SHA1)); - } - - block_reader_release(&br); - block_iter_close(&it); - reftable_record_release(&rec); - reftable_block_done(&br.block); - reftable_buf_release(&want); - reftable_buf_release(&buf); - for (i = 0; i < N; i++) - reftable_record_release(&recs[i]); -} - -static void t_obj_block_read_write(void) -{ - const int header_off = 21; - struct reftable_record recs[30]; - const size_t N = ARRAY_SIZE(recs); - const size_t block_size = 1024; - struct reftable_block block = { 0 }; - struct block_writer bw = { - .last_key = REFTABLE_BUF_INIT, - }; - struct reftable_record rec = { - .type = BLOCK_TYPE_OBJ, - }; - size_t i = 0; - int ret; - struct block_reader br = { 0 }; - struct block_iter it = BLOCK_ITER_INIT; - struct reftable_buf want = REFTABLE_BUF_INIT, buf = REFTABLE_BUF_INIT; - - REFTABLE_CALLOC_ARRAY(block.data, block_size); - check(block.data != NULL); - block.len = block_size; - block_source_from_buf(&block.source, &buf); - ret = block_writer_init(&bw, BLOCK_TYPE_OBJ, block.data, block_size, - header_off, hash_size(REFTABLE_HASH_SHA1)); - check(!ret); - - for (i = 0; i < N; i++) { - uint8_t bytes[] = { i, i + 1, i + 2, i + 3, i + 5 }, *allocated; - DUP_ARRAY(allocated, bytes, ARRAY_SIZE(bytes)); - - rec.u.obj.hash_prefix = allocated; - rec.u.obj.hash_prefix_len = 5; - - recs[i] = rec; - ret = block_writer_add(&bw, &rec); - rec.u.obj.hash_prefix = NULL; - rec.u.obj.hash_prefix_len = 0; - check_int(ret, ==, 0); - } - - ret = block_writer_finish(&bw); - check_int(ret, >, 0); - - block_writer_release(&bw); - - block_reader_init(&br, &block, header_off, block_size, REFTABLE_HASH_SIZE_SHA1); - - block_iter_seek_start(&it, &br); - - for (i = 0; ; i++) { - ret = block_iter_next(&it, &rec); - check_int(ret, >=, 0); - if (ret > 0) { - check_int(i, ==, N); - break; - } - check(reftable_record_equal(&recs[i], &rec, REFTABLE_HASH_SIZE_SHA1)); - } - - for (i = 0; i < N; i++) { - block_iter_reset(&it); - reftable_record_key(&recs[i], &want); - - ret = block_iter_seek_key(&it, &br, &want); - check_int(ret, ==, 0); - - ret = block_iter_next(&it, &rec); - check_int(ret, ==, 0); - - check(reftable_record_equal(&recs[i], &rec, REFTABLE_HASH_SIZE_SHA1)); - } - - block_reader_release(&br); - block_iter_close(&it); - reftable_record_release(&rec); - reftable_block_done(&br.block); - reftable_buf_release(&want); - reftable_buf_release(&buf); - for (i = 0; i < N; i++) - reftable_record_release(&recs[i]); -} - -static void t_index_block_read_write(void) -{ - const int header_off = 21; - struct reftable_record recs[30]; - const size_t N = ARRAY_SIZE(recs); - const size_t block_size = 1024; - struct reftable_block block = { 0 }; - struct block_writer bw = { - .last_key = REFTABLE_BUF_INIT, - }; - struct reftable_record rec = { - .type = BLOCK_TYPE_INDEX, - .u.idx.last_key = REFTABLE_BUF_INIT, - }; - size_t i = 0; - int ret; - struct block_reader br = { 0 }; - struct block_iter it = BLOCK_ITER_INIT; - struct reftable_buf want = REFTABLE_BUF_INIT, buf = REFTABLE_BUF_INIT; - - REFTABLE_CALLOC_ARRAY(block.data, block_size); - check(block.data != NULL); - block.len = block_size; - block_source_from_buf(&block.source, &buf); - ret = block_writer_init(&bw, BLOCK_TYPE_INDEX, block.data, block_size, - header_off, hash_size(REFTABLE_HASH_SHA1)); - check(!ret); - - for (i = 0; i < N; i++) { - char buf[128]; - - snprintf(buf, sizeof(buf), "branch%02"PRIuMAX, (uintmax_t)i); - - reftable_buf_init(&recs[i].u.idx.last_key); - recs[i].type = BLOCK_TYPE_INDEX; - check(!reftable_buf_addstr(&recs[i].u.idx.last_key, buf)); - recs[i].u.idx.offset = i; - - ret = block_writer_add(&bw, &recs[i]); - check_int(ret, ==, 0); - } - - ret = block_writer_finish(&bw); - check_int(ret, >, 0); - - block_writer_release(&bw); - - block_reader_init(&br, &block, header_off, block_size, REFTABLE_HASH_SIZE_SHA1); - - block_iter_seek_start(&it, &br); - - for (i = 0; ; i++) { - ret = block_iter_next(&it, &rec); - check_int(ret, >=, 0); - if (ret > 0) { - check_int(i, ==, N); - break; - } - check(reftable_record_equal(&recs[i], &rec, REFTABLE_HASH_SIZE_SHA1)); - } - - for (i = 0; i < N; i++) { - block_iter_reset(&it); - reftable_record_key(&recs[i], &want); - - ret = block_iter_seek_key(&it, &br, &want); - check_int(ret, ==, 0); - - ret = block_iter_next(&it, &rec); - check_int(ret, ==, 0); - - check(reftable_record_equal(&recs[i], &rec, REFTABLE_HASH_SIZE_SHA1)); - - want.len--; - ret = block_iter_seek_key(&it, &br, &want); - check_int(ret, ==, 0); - - ret = block_iter_next(&it, &rec); - check_int(ret, ==, 0); - check(reftable_record_equal(&recs[10 * (i / 10)], &rec, REFTABLE_HASH_SIZE_SHA1)); - } - - block_reader_release(&br); - block_iter_close(&it); - reftable_record_release(&rec); - reftable_block_done(&br.block); - reftable_buf_release(&want); - reftable_buf_release(&buf); - for (i = 0; i < N; i++) - reftable_record_release(&recs[i]); -} - -int cmd_main(int argc UNUSED, const char *argv[] UNUSED) -{ - TEST(t_index_block_read_write(), "read-write operations on index blocks work"); - TEST(t_log_block_read_write(), "read-write operations on log blocks work"); - TEST(t_obj_block_read_write(), "read-write operations on obj blocks work"); - TEST(t_ref_block_read_write(), "read-write operations on ref blocks work"); - - return test_done(); -} diff --git a/t/unit-tests/u-reftable-block.c b/t/unit-tests/u-reftable-block.c new file mode 100644 index 0000000000..af24901230 --- /dev/null +++ b/t/unit-tests/u-reftable-block.c @@ -0,0 +1,373 @@ +/* +Copyright 2020 Google LLC + +Use of this source code is governed by a BSD-style +license that can be found in the LICENSE file or at +https://developers.google.com/open-source/licenses/bsd +*/ + +#include "unit-test.h" +#include "reftable/block.h" +#include "reftable/blocksource.h" +#include "reftable/constants.h" +#include "reftable/reftable-error.h" +#include "strbuf.h" + +void test_reftable_block__index_read_write(void) +{ + const int header_off = 21; /* random */ + struct reftable_record recs[30]; + const size_t N = ARRAY_SIZE(recs); + const size_t block_size = 1024; + struct reftable_block block = { 0 }; + struct block_writer bw = { + .last_key = REFTABLE_BUF_INIT, + }; + struct reftable_record rec = { + .type = BLOCK_TYPE_REF, + }; + size_t i = 0; + int ret; + struct block_reader br = { 0 }; + struct block_iter it = BLOCK_ITER_INIT; + struct reftable_buf want = REFTABLE_BUF_INIT, buf = REFTABLE_BUF_INIT; + + REFTABLE_CALLOC_ARRAY(block.data, block_size); + cl_assert(block.data != NULL); + block.len = block_size; + block_source_from_buf(&block.source ,&buf); + ret = block_writer_init(&bw, BLOCK_TYPE_REF, block.data, block_size, + header_off, hash_size(REFTABLE_HASH_SHA1)); + cl_assert(ret == 0); + + rec.u.ref.refname = (char *) ""; + rec.u.ref.value_type = REFTABLE_REF_DELETION; + ret = block_writer_add(&bw, &rec); + cl_assert_equal_i(ret, REFTABLE_API_ERROR); + + for (i = 0; i < N; i++) { + rec.u.ref.refname = xstrfmt("branch%02"PRIuMAX, (uintmax_t)i); + rec.u.ref.value_type = REFTABLE_REF_VAL1; + memset(rec.u.ref.value.val1, i, REFTABLE_HASH_SIZE_SHA1); + + recs[i] = rec; + ret = block_writer_add(&bw, &rec); + rec.u.ref.refname = NULL; + rec.u.ref.value_type = REFTABLE_REF_DELETION; + cl_assert_equal_i(ret, 0); + } + + ret = block_writer_finish(&bw); + cl_assert(ret > 0); + + block_writer_release(&bw); + + block_reader_init(&br, &block, header_off, block_size, REFTABLE_HASH_SIZE_SHA1); + + block_iter_seek_start(&it, &br); + + for (i = 0; ; i++) { + ret = block_iter_next(&it, &rec); + cl_assert(ret >= 0); + if (ret > 0) { + cl_assert_equal_i(i, N); + break; + } + cl_assert_equal_i(reftable_record_equal(&recs[i], &rec, REFTABLE_HASH_SIZE_SHA1), 1); + } + + for (i = 0; i < N; i++) { + block_iter_reset(&it); + reftable_record_key(&recs[i], &want); + + ret = block_iter_seek_key(&it, &br, &want); + cl_assert_equal_i(ret, 0); + + ret = block_iter_next(&it, &rec); + cl_assert_equal_i(ret, 0); + + cl_assert_equal_i(reftable_record_equal(&recs[i], &rec, REFTABLE_HASH_SIZE_SHA1), 1); + + want.len--; + ret = block_iter_seek_key(&it, &br, &want); + cl_assert_equal_i(ret, 0); + + ret = block_iter_next(&it, &rec); + cl_assert_equal_i(ret, 0); + cl_assert_equal_i(reftable_record_equal(&recs[10 * (i / 10)], &rec, REFTABLE_HASH_SIZE_SHA1), 1); + } + + block_reader_release(&br); + block_iter_close(&it); + reftable_record_release(&rec); + reftable_block_done(&br.block); + reftable_buf_release(&want); + reftable_buf_release(&buf); + for (i = 0; i < N; i++) + reftable_record_release(&recs[i]); +} + +void test_reftable_block__log_read_write(void) +{ + const int header_off = 21; + struct reftable_record recs[30]; + const size_t N = ARRAY_SIZE(recs); + const size_t block_size = 2048; + struct reftable_block block = { 0 }; + struct block_writer bw = { + .last_key = REFTABLE_BUF_INIT, + }; + struct reftable_record rec = { + .type = BLOCK_TYPE_LOG, + }; + size_t i = 0; + int ret; + struct block_reader br = { 0 }; + struct block_iter it = BLOCK_ITER_INIT; + struct reftable_buf want = REFTABLE_BUF_INIT, buf = REFTABLE_BUF_INIT; + + REFTABLE_CALLOC_ARRAY(block.data, block_size); + cl_assert(block.data != NULL); + block.len = block_size; + block_source_from_buf(&block.source ,&buf); + ret = block_writer_init(&bw, BLOCK_TYPE_LOG, block.data, block_size, + header_off, hash_size(REFTABLE_HASH_SHA1)); + cl_assert(ret == 0); + + for (i = 0; i < N; i++) { + rec.u.log.refname = xstrfmt("branch%02"PRIuMAX , (uintmax_t)i); + rec.u.log.update_index = i; + rec.u.log.value_type = REFTABLE_LOG_UPDATE; + + recs[i] = rec; + ret = block_writer_add(&bw, &rec); + rec.u.log.refname = NULL; + rec.u.log.value_type = REFTABLE_LOG_DELETION; + cl_assert_equal_i(ret, 0); + } + + ret = block_writer_finish(&bw); + cl_assert(ret > 0); + + block_writer_release(&bw); + + block_reader_init(&br, &block, header_off, block_size, REFTABLE_HASH_SIZE_SHA1); + + block_iter_seek_start(&it, &br); + + for (i = 0; ; i++) { + ret = block_iter_next(&it, &rec); + cl_assert(ret >= 0); + if (ret > 0) { + cl_assert_equal_i(i, N); + break; + } + cl_assert_equal_i(reftable_record_equal(&recs[i], &rec, REFTABLE_HASH_SIZE_SHA1), 1); + } + + for (i = 0; i < N; i++) { + block_iter_reset(&it); + reftable_buf_reset(&want); + cl_assert(reftable_buf_addstr(&want, recs[i].u.log.refname) == 0); + + ret = block_iter_seek_key(&it, &br, &want); + cl_assert_equal_i(ret, 0); + + ret = block_iter_next(&it, &rec); + cl_assert_equal_i(ret, 0); + + cl_assert_equal_i(reftable_record_equal(&recs[i], &rec, REFTABLE_HASH_SIZE_SHA1), 1); + + want.len--; + ret = block_iter_seek_key(&it, &br, &want); + cl_assert_equal_i(ret, 0); + + ret = block_iter_next(&it, &rec); + cl_assert_equal_i(ret, 0); + cl_assert_equal_i(reftable_record_equal(&recs[10 * (i / 10)], &rec, REFTABLE_HASH_SIZE_SHA1), 1); + } + + block_reader_release(&br); + block_iter_close(&it); + reftable_record_release(&rec); + reftable_block_done(&br.block); + reftable_buf_release(&want); + reftable_buf_release(&buf); + for (i = 0; i < N; i++) + reftable_record_release(&recs[i]); +} + +void test_reftable_block__obj_read_write(void) +{ + const int header_off = 21; + struct reftable_record recs[30]; + const size_t N = ARRAY_SIZE(recs); + const size_t block_size = 1024; + struct reftable_block block = { 0 }; + struct block_writer bw = { + .last_key = REFTABLE_BUF_INIT, + }; + struct reftable_record rec = { + .type = BLOCK_TYPE_OBJ, + }; + size_t i = 0; + int ret; + struct block_reader br = { 0 }; + struct block_iter it = BLOCK_ITER_INIT; + struct reftable_buf want = REFTABLE_BUF_INIT, buf = REFTABLE_BUF_INIT; + + REFTABLE_CALLOC_ARRAY(block.data, block_size); + cl_assert(block.data != NULL); + block.len = block_size; + block_source_from_buf(&block.source, &buf); + ret = block_writer_init(&bw, BLOCK_TYPE_OBJ, block.data, block_size, + header_off, hash_size(REFTABLE_HASH_SHA1)); + cl_assert(ret == 0); + + for (i = 0; i < N; i++) { + uint8_t bytes[] = { i, i + 1, i + 2, i + 3, i + 5 }, *allocated; + DUP_ARRAY(allocated, bytes, ARRAY_SIZE(bytes)); + + rec.u.obj.hash_prefix = allocated; + rec.u.obj.hash_prefix_len = 5; + + recs[i] = rec; + ret = block_writer_add(&bw, &rec); + rec.u.obj.hash_prefix = NULL; + rec.u.obj.hash_prefix_len = 0; + cl_assert_equal_i(ret, 0); + } + + ret = block_writer_finish(&bw); + cl_assert(ret > 0); + + block_writer_release(&bw); + + block_reader_init(&br, &block, header_off, block_size, REFTABLE_HASH_SIZE_SHA1); + + block_iter_seek_start(&it, &br); + + for (i = 0; ; i++) { + ret = block_iter_next(&it, &rec); + cl_assert(ret >= 0); + if (ret > 0) { + cl_assert_equal_i(i, N); + break; + } + cl_assert_equal_i(reftable_record_equal(&recs[i], &rec, REFTABLE_HASH_SIZE_SHA1), 1); + } + + for (i = 0; i < N; i++) { + block_iter_reset(&it); + reftable_record_key(&recs[i], &want); + + ret = block_iter_seek_key(&it, &br, &want); + cl_assert_equal_i(ret, 0); + + ret = block_iter_next(&it, &rec); + cl_assert_equal_i(ret, 0); + + cl_assert_equal_i(reftable_record_equal(&recs[i], &rec, REFTABLE_HASH_SIZE_SHA1), 1); + } + + block_reader_release(&br); + block_iter_close(&it); + reftable_record_release(&rec); + reftable_block_done(&br.block); + reftable_buf_release(&want); + reftable_buf_release(&buf); + for (i = 0; i < N; i++) + reftable_record_release(&recs[i]); +} + +void test_reftable_block__ref_read_write(void) +{ + const int header_off = 21; + struct reftable_record recs[30]; + const size_t N = ARRAY_SIZE(recs); + const size_t block_size = 1024; + struct reftable_block block = { 0 }; + struct block_writer bw = { + .last_key = REFTABLE_BUF_INIT, + }; + struct reftable_record rec = { + .type = BLOCK_TYPE_INDEX, + .u.idx.last_key = REFTABLE_BUF_INIT, + }; + size_t i = 0; + int ret; + struct block_reader br = { 0 }; + struct block_iter it = BLOCK_ITER_INIT; + struct reftable_buf want = REFTABLE_BUF_INIT, buf = REFTABLE_BUF_INIT; + + REFTABLE_CALLOC_ARRAY(block.data, block_size); + cl_assert(block.data != NULL); + block.len = block_size; + block_source_from_buf(&block.source, &buf); + ret = block_writer_init(&bw, BLOCK_TYPE_INDEX, block.data, block_size, + header_off, hash_size(REFTABLE_HASH_SHA1)); + cl_assert(ret == 0); + + for (i = 0; i < N; i++) { + char buf[128]; + + snprintf(buf, sizeof(buf), "branch%02"PRIuMAX, (uintmax_t)i); + + reftable_buf_init(&recs[i].u.idx.last_key); + recs[i].type = BLOCK_TYPE_INDEX; + cl_assert(reftable_buf_addstr(&recs[i].u.idx.last_key, buf) == 0); + recs[i].u.idx.offset = i; + + ret = block_writer_add(&bw, &recs[i]); + cl_assert_equal_i(ret, 0); + } + + ret = block_writer_finish(&bw); + cl_assert(ret > 0); + + block_writer_release(&bw); + + block_reader_init(&br, &block, header_off, block_size, REFTABLE_HASH_SIZE_SHA1); + + block_iter_seek_start(&it, &br); + + for (i = 0; ; i++) { + ret = block_iter_next(&it, &rec); + cl_assert(ret >= 0); + if (ret > 0) { + cl_assert_equal_i(i, N); + break; + } + cl_assert_equal_i(reftable_record_equal(&recs[i], &rec, REFTABLE_HASH_SIZE_SHA1), 1); + } + + for (i = 0; i < N; i++) { + block_iter_reset(&it); + reftable_record_key(&recs[i], &want); + + ret = block_iter_seek_key(&it, &br, &want); + cl_assert_equal_i(ret, 0); + + ret = block_iter_next(&it, &rec); + cl_assert_equal_i(ret, 0); + + cl_assert_equal_i(reftable_record_equal(&recs[i], &rec, REFTABLE_HASH_SIZE_SHA1), 1); + + want.len--; + ret = block_iter_seek_key(&it, &br, &want); + cl_assert_equal_i(ret, 0); + + ret = block_iter_next(&it, &rec); + cl_assert_equal_i(ret, 0); + cl_assert_equal_i(reftable_record_equal(&recs[10 * (i / 10)], &rec, REFTABLE_HASH_SIZE_SHA1), 1); + } + + block_reader_release(&br); + block_iter_close(&it); + reftable_record_release(&rec); + reftable_block_done(&br.block); + reftable_buf_release(&want); + reftable_buf_release(&buf); + for (i = 0; i < N; i++) + reftable_record_release(&recs[i]); +}
-- 2.43.0