[PATCH 2/2] builtin/difftool: remove unnecessary if statement
- From
Usman Akinyemi <usmanakinyemi202@gmail.com>
- Date
- Apr 20, 2025, 02:54 UTC
- Message-ID
- <20250420025501.183290-3-usmanakinyemi202@gmail.com>
- In-Reply-To
- <20250420025501.183290-1-usmanakinyemi202@gmail.com>
Since we already teach the `repo_config()` in "f29f1990b5 (config: teach repo_config to allow `repo` to be NULL, 2025-03-08)" to allow `repo` to be NULL, no need to check if `repo` is NULL before calling `repo_config()`.
Suggested-by: Patrick Steinhardt <ps@pks.im> Mentored-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com> --- builtin/difftool.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/builtin/difftool.c b/builtin/difftool.c index 41cd00066c..c7348a1dca 100644 --- a/builtin/difftool.c +++ b/builtin/difftool.c @@ -750,8 +750,7 @@ int cmd_difftool(int argc, }; struct child_process child = CHILD_PROCESS_INIT; - if (repo) - repo_config(repo, difftool_config, &dt_options); + repo_config(repo, difftool_config, &dt_options); dt_options.symlinks = dt_options.has_symlinks; argc = parse_options(argc, argv, prefix, builtin_difftool_options,
-- 2.49.0