git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t7422: remove extraneous argument to printf

From
SNSubhaditya Nath <sn03.general@gmail.com>
Date
Apr 3, 2025, 14:48 UTC
Message-ID
<20250403144852.19153-1-sn03.general@gmail.com>
The POSIX man page of printf(1) mentions -
> If the format operand contains no conversion specifications and
> argument operands are present, the results are unspecified.

In practice, this means some printf implementations throw an error when provided with extra operands, thereby causing the test to fail erroneously. This commit fixes that issue.

Signed-off-by: Subhaditya Nath <sn03.general@gmail.com>
---
 t/t7422-submodule-output.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t7422-submodule-output.sh b/t/t7422-submodule-output.sh
index 023a5cbdc4..1f291a1d49 100755
--- a/t/t7422-submodule-output.sh
+++ b/t/t7422-submodule-output.sh
@@ -180,7 +180,7 @@ test_expect_success !MINGW 'git submodule status --recursive propagates SIGPIPE'
 		COMMIT=$(git rev-parse HEAD) &&
 		for i in $(test_seq 2000)
 		do
-			printf "[submodule \"sm-$i\"]\npath = recursive-submodule-path-$i\n" "$i" ||
+			printf "[submodule \"sm-$i\"]\npath = recursive-submodule-path-$i\n" ||
 			return 1
 		done >gitmodules &&
 		BLOB=$(git hash-object -w --stdin <gitmodules) &&
-- 
2.48.1
Next: Eric Sunshine
Message 1 of 10 in “t7422: remove extraneous argument to printf”
  1. t7422: remove extraneous argument to printfSubhaditya Nath, Apr 3, 2025
  2. Eric SunshineApr 3, 2025
  3. Junio C HamanoApr 9, 2025
  4. Subhaditya NathApr 9, 2025
  5. Subhaditya NathApr 9, 2025
  6. Eric SunshineApr 9, 2025
  7. Junio C HamanoApr 9, 2025
  8. t7422: fix extra printf argument, eliminate loopsSubhaditya Nath, Apr 9, 2025
  9. t7422: fix extra printf argument, eliminate loopsSubhaditya Nath, Apr 9, 2025
  10. Junio C HamanoApr 10, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.