Re: [PATCH] format-patch: use raw format for notes
- From
Tuomas Ahola <taahol@utu.fi>
- Date
- Mar 18, 2025, 21:30 UTC
- Message-ID
- <20250318.233012.1423505396684882738.taahol@utu.fi>
- In-Reply-To
- <xmqqy0x2yr6b.fsf@gitster.g>
From: Junio C Hamano <gitster@pobox.com> Subject: Re: [PATCH] format-patch: use raw format for notes Date: Tue, 18 Mar 2025 14:17:32 -0700
> [--] more importantly, the contents of the note loses its crucial > leading spaces that makes sure that any random lines in the note > that happen to begin with "diff", "---", etc. are not mistaken as > the beginning of the first patch.
Thanks for quick response. That was indeed a compelling point.
> So, no, this change is not a good thing to do, at least in its > current form. Besides, unconditional change like this will break > existing users.
I see that similar patch was proposed in 2017. I should have searched more thoroughly, I guess.
--Tuomas A.