git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 5/6] xdiff: avoid signed vs. unsigned comparisons in xpatience.c

From
David Aguilar <davvid@gmail.com>
Date
Feb 12, 2025, 06:04 UTC
Message-ID
<20250212060418.1645241-5-davvid@gmail.com>
In-Reply-To
<20250212060418.1645241-1-davvid@gmail.com>

The loop iteration variable is non-negative and used in comparisons against a size_t value. Use size_t to eliminate the mismatch.

Signed-off-by: David Aguilar <davvid@gmail.com>
---
 xdiff/xpatience.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/xdiff/xpatience.c b/xdiff/xpatience.c
index b0ba421b28..82f663004e 100644
--- a/xdiff/xpatience.c
+++ b/xdiff/xpatience.c
@@ -20,8 +20,6 @@
  *
  */
 
-#define DISABLE_SIGN_COMPARE_WARNINGS
-
 #include "xinclude.h"
 
 /*
@@ -78,7 +76,7 @@ struct hashmap {
 
 static int is_anchor(xpparam_t const *xpp, const char *line)
 {
-	int i;
+	size_t i;
 	for (i = 0; i < xpp->anchors_nr; i++) {
 		if (!strncmp(line, xpp->anchors[i], strlen(xpp->anchors[i])))
 			return 1;
-- 
2.48.1.643.g61982db19f
Previous: David AguilarNext: David Aguilar
Message 5 of 6 in “xdiff: move sign comparison warning guard into each file”
  1. 1/6 xdiff: move sign comparison warning guard into each fileDavid Aguilar, Feb 12, 2025
  2. 2/6 xdiff: avoid signed vs. unsigned comparisons in xdiffi.cDavid Aguilar, Feb 12, 2025
  3. 3/6 xdiff: avoid signed vs. unsigned comparisons in xemit.cDavid Aguilar, Feb 12, 2025
  4. 4/6 xdiff: avoid signed vs. unsigned comparisons in xhistogram.cDavid Aguilar, Feb 12, 2025
  5. 5/6 xdiff: avoid signed vs. unsigned comparisons in xpatience.cDavid Aguilar, Feb 12, 2025
  6. 6/6 xdiff: avoid signed vs. unsigned comparisons in xutils.cDavid Aguilar, Feb 12, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.