git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 03/10] compat: introduce new "zlib.h" header

From
Patrick Steinhardt <ps@pks.im>
Date
Jan 28, 2025, 08:41 UTC
Message-ID
<20250128-b4-pks-compat-drop-uncompress2-v4-3-129bc36ae8f5@pks.im>
In-Reply-To
<20250128-b4-pks-compat-drop-uncompress2-v4-0-129bc36ae8f5@pks.im>

Introduce a new "compat/zlib-compat.h" header that we include instead of including <zlib.h> directly. This will allow us to wire up zlib-ng as an alternative backend for zlib compression in a subsequent commit.

Note that we cannot just call the file "compat/zlib.h", as that may otherwise cause us to include that file instead of <zlib.h>.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
---
 compat/zlib-compat.h | 6 ++++++
 git-compat-util.h    | 2 +-
 reftable/block.c     | 2 +-
 3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/compat/zlib-compat.h b/compat/zlib-compat.h
new file mode 100644
index 0000000000..bc20b884ef
--- /dev/null
+++ b/compat/zlib-compat.h
@@ -0,0 +1,6 @@
+#ifndef COMPAT_ZLIB_H
+#define COMPAT_ZLIB_H
+
+#include <zlib.h>
+
+#endif /* COMPAT_ZLIB_H */
diff --git a/git-compat-util.h b/git-compat-util.h
index c4b4b372b4..1ca2671322 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -1537,7 +1537,7 @@ int cmd_main(int, const char **);
 int common_exit(const char *file, int line, int code);
 #define exit(code) exit(common_exit(__FILE__, __LINE__, (code)))
 
-#include <zlib.h>
+#include "compat/zlib-compat.h"
 
 /*
  * This include must come after system headers, since it introduces macros that
diff --git a/reftable/block.c b/reftable/block.c
index 9858bbc7c5..bc9b079634 100644
--- a/reftable/block.c
+++ b/reftable/block.c
@@ -13,7 +13,7 @@ license that can be found in the LICENSE file or at
 #include "record.h"
 #include "reftable-error.h"
 #include "system.h"
-#include <zlib.h>
+#include "compat/zlib-compat.h"
 
 int header_size(int version)
 {
-- 
2.48.1.362.g079036d154.dirty
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 4 of 12 in “compat/zlib: allow use of zlib-ng as backend”
  1. 00/10 compat/zlib: allow use of zlib-ng as backendPatrick Steinhardt, Jan 28, 2025
  2. 01/10 compat: drop `uncompress2()` compatibility shimPatrick Steinhardt, Jan 28, 2025
  3. 02/10 git-compat-util: drop `z_const` definePatrick Steinhardt, Jan 28, 2025
  4. 03/10 compat: introduce new "zlib.h" headerPatrick Steinhardt, Jan 28, 2025
  5. 04/10 git-compat-util: move include of "compat/zlib.h" into "git-zlib.h"Patrick Steinhardt, Jan 28, 2025
  6. 05/10 compat/zlib: provide `deflateBound()` shim centrallyPatrick Steinhardt, Jan 28, 2025
  7. 06/10 compat/zlib: provide stubs for `deflateSetHeader()`Patrick Steinhardt, Jan 28, 2025
  8. 07/10 git-zlib: cast away potential constness of `next_in` pointerPatrick Steinhardt, Jan 28, 2025
  9. 08/10 compat/zlib: allow use of zlib-ng as backendPatrick Steinhardt, Jan 28, 2025
  10. 09/10 ci: switch linux-musl to use MesonPatrick Steinhardt, Jan 28, 2025
  11. 10/10 ci: make "linux-musl" job use zlib-ngPatrick Steinhardt, Jan 28, 2025
  12. Junio C HamanoJan 28, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.