git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC PATCH 0/3] refspec: centralize refspec-related logic

From
Meet Soni <meetsoni3017@gmail.com>
Date
Jan 22, 2025, 07:51 UTC
Message-ID
<20250122075154.5697-1-meetsoni3017@gmail.com>

As Patrick pointed out in [1], the logic related to refspec is currently split across multiple headers. This patch series addresses that by relocating refspec-related logic from remote to refspec for improved cohesion.

There are a few functions that seem to be on the borderline. They seem to have refspec-related logic, but also contain some elements related to remote logic, so I'm unsure whether they should be moved. Specifically:

    * get_fetch_map()
    * count_refspec_match()
    * check_push_refs()
    * match_push_refs()
[1]: https://lore.kernel.org/git/ZysQvUyxgdRqjvj2@pks.im/
Meet Soni (3):
  refspec: relocate omit_name_by_refspec and related functions
  refspec: relocate query related functions
  refspec: relocate apply_refspecs and related funtions
 refspec.c | 203 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
 refspec.h |  23 +++++++
 remote.c  | 201 -----------------------------------------------------
 remote.h  |  15 ----
 4 files changed, 226 insertions(+), 216 deletions(-)
base-commit: efff4a85a4fce58b2aa850c6fbf4d8828329f51d
-- 
2.34.1
Next: Meet Soni
Message 1 of 9 in “refspec: centralize refspec-related logic”
  1. 0/3 refspec: centralize refspec-related logicMeet Soni, Jan 22, 2025
  2. 1/3 refspec: relocate omit_name_by_refspec and related functionsMeet Soni, Jan 22, 2025
  3. Patrick SteinhardtJan 24, 2025
  4. 2/3 refspec: relocate query related functionsMeet Soni, Jan 22, 2025
  5. Patrick SteinhardtJan 24, 2025
  6. 3/3 refspec: relocate apply_refspecs and related funtionsMeet Soni, Jan 22, 2025
  7. Patrick SteinhardtJan 24, 2025
  8. Patrick SteinhardtJan 24, 2025
  9. Junio C HamanoJan 24, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.