git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] prio-queue: use size_t rather than int for size

From
Jeff King <peff@peff.net>
Date
Dec 20, 2024, 16:01 UTC
Message-ID
<20241220160153.GE152570@coredump.intra.peff.net>
In-Reply-To
<xmqqh66yfk89.fsf@gitster.g>
On Fri, Dec 20, 2024 at 07:27:18AM -0800, Junio C Hamano wrote:
Show 11 quoted lines
> > Sorry, just realized that "diff --check" (and apply) complains about the
> > indentation here. It's a TAB followed by 14 spaces, instead of two TABs
> > followed by 6 spaces. I guess caused by me lining things up manually.
> 
> "git am --whitespace=fix" with or without "-3" corrects such
> glitches just fine, and "git am --whitespace=error" correctly stops
> me from applying such a patch.
> 
> What is worrysome is "git am -3 --whitespace=warn" does not seem to
> catch it (without "-3" it works just fine).  I do not know offhand
> if this is a recent regression or not.

Interesting. I noticed with stock "git am" (I sometimes "reset --hard" and reapply my own patches because I made tweaks to the commit message while sending).

Looks like it does not warn even going back to v2.0.5 (my stock "this was a long time ago" version). Curiously if you accidentally try to apply the patch a second time, it does notice the problem.

So I agree it's a bug, but I think it has been around for a while.
-Peff
Previous: Junio C HamanoNext: Patrick Steinhardt
Message 4 of 6 in “prio-queue: use size_t rather than int for size”
  1. prio-queue: use size_t rather than int for sizeJeff King, Dec 20, 2024
  2. Jeff KingDec 20, 2024
  3. Junio C HamanoDec 20, 2024
  4. Jeff KingDec 20, 2024
  5. Patrick SteinhardtDec 27, 2024
  6. Jeff KingDec 27, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.