Re: Regression in :/ commit selection between 2.43.0 and 2.47.1

From: Jeff King <peff@peff.net>
Date: Dec 5, 2024, 17:33 UTC
Message-ID: <20241205173342.GA2593033@coredump.intra.peff.net>
In-Reply-To: <CAKOEJdcPYn3O01p29rVa+xv=Qr504FQyKJeSB-Moze04ViCGGg@mail.gmail.com>

On Thu, Dec 05, 2024 at 02:22:13PM +0200, Aarni Koskela wrote:

Show 10 quoted lines

> See below for a reproduction:
> 
> * Initialize a repository
> * Create a commit with message "mystery commit 1"
> * Tag the commit with `git tag -a a-tag -m a-tag`
> * Create another commit with message "mystery commit 2" (which should
> be found from HEAD with `:/mystery`)
> * Show the commit with `git show :/mystery` – it shows the older commit!
> * Delete the tag with `git tag -d a-tag`
> * Show the commit with `git show :/mystery` – it now shows the newer commit.

This bisects to 57fb139b5e (object-name: fix leaking commit list items, 2024-08-01). Looks like an unintended side effect, maybe related to swapping "list" and "copy" in get_oid_oneline()?

-Peff