Re: [PATCH] builtin/gc: provide hint when maintenance hits a stale schedule lock

From: Jeff King <peff@peff.net>
Date: Nov 22, 2024, 15:30 UTC
Message-ID: <20241122153033.GA1737136@coredump.intra.peff.net>
In-Reply-To: <20241119-pks-maintenance-hint-with-stale-lock-v1-1-f9f9a98e12a0@pks.im>

On Tue, Nov 19, 2024 at 11:48:43AM +0100, Patrick Steinhardt wrote:

Show 15 quoted lines

> diff --git a/t/t7900-maintenance.sh b/t/t7900-maintenance.sh
> index c224c8450c85f567bc29258e18b4a59fe6682f0a..6d6ffaaf376bdbadecdb23a460994af1d218dc19 100755
> --- a/t/t7900-maintenance.sh
> +++ b/t/t7900-maintenance.sh
> @@ -1011,4 +1011,12 @@ test_expect_success 'repacking loose objects is quiet' '
>  	)
>  '
>  
> +test_expect_success 'maintenance aborts with existing lock file' '
> +	test_when_finished "rm -rf repo" &&
> +	git init repo &&
> +	: >repo/.git/objects/schedule.lock &&
> +	test_must_fail git -C repo maintenance start 2>err &&
> +	test_grep "Another scheduled git-maintenance(1) process seems to be running" err
> +'

This failed for me in all of the macos jobs of GitHub CI. Looks like the err file contains:

  fatal: launchctl scheduler is not available

So maybe it's a platform image issue?

-Peff