Re: [PATCH] t6300: values containing ')' are broken in ref formats

From: Jeff King <peff@peff.net>
Date: Nov 6, 2024, 18:55 UTC
Message-ID: <20241106185511.GB880133@coredump.intra.peff.net>
In-Reply-To: <ZyroYBwtQtgc6NoR@five231003>

On Wed, Nov 06, 2024 at 09:24:08AM +0530, Kousik Sanagavarapu wrote:

Show 6 quoted lines

> One way to fix this is refactoring the way in which we parse our format
> string.  Although this would mean we would have to do a huge refactoring
> as this step happens very high up in the call chain.
> 
> Therefore, support including parenthesis characters in "<string>" by
> instead giving their hexcode equivalents - as a for-now hack.

So if I understand this is just expanding %<hex> and nothing else? That seems like the worst of both worlds. Now "%" is magic in these value strings, breaking compatibility, but we didn't buy ourselves the flexibility to do arbitrary comparisons like:

  %(if:equals=%(upstream:lstrip=3))%(refname:short)%(then)...

-Peff