Re: What's so special about almalinux-8?

From: Jonathan Tan <jonathantanmy@google.com>
Date: Nov 5, 2024, 18:54 UTC
Message-ID: <20241105185439.3230561-1-jonathantanmy@google.com>
In-Reply-To: <xmqqbjyuted3.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 9 quoted lines

> Everybody else seems to pass tests, but not this one
> 
>   https://github.com/git/git/actions/runs/11677884048/job/32516504151#step:6:1995
> 
> I am not (yet) so familiar with the topics in flight at this point,
> but there are a few topics that deal with packing, lazy fetching,
> and commit-graph and object database being out of sync, which were
> handled by a few topics by Jonathan, so I am CC'ing this if it rings
> bell for him.

That run refers to 95dcd58, so I fetched it and tried rerunning it on CI. It seems to pass:

  https://github.com/jonathantanmy/git/actions/runs/11690124087

Having said that, I'm not sure what caused it to fail.

Show 7 quoted lines

>   ++ git -C dst rev-list --missing=error --objects main
>   fatal: You are attempting to fetch 957c60b67968d2ab4144e7e2fbba99d6ad864e4e, which is in the commit graph file but not in the object database.
>   This is probably due to repo corruption.
>   If you are attempting to repair this repo corruption by refetching the missing object, use 'git fetch --refetch' with the missing object.
>   fatal: could not fetch 3246c304205324149983025431c5211438f41931 from promisor remote
>   error: last command exited with $?=128
>   not ok 22 - use fsck before and after manually fetching a missing subtree

This is supposed to happen when we have a commit in the commit graph
file but not in the object DB, but the test is not testing that case -
"dst" was cloned normally and we did not manipulate its object DB in any
way (outside regular Git commands). So I'm not sure what happened.