git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] Restore support for older libcurl and fix some typos

From
Alejandro R. Sedeño <asedeno@mit.edu>
Date
Oct 14, 2024, 13:13 UTC
Message-ID
<20241014131346.3556163-1-asedeno@mit.edu>
Hi,

This is the small patchset I've mentioned on a couple of threads in the past few days [1, 2].

The first patch adds a version check for CURLOPT_PROXYHEADER in git-curl-compat.h and uses it to wrap the one use of CURLOPT_PROXYHEADER, replacing it with a translatable warning if it's used on an older version of libcurl.

The second patch adjusts some typos I noticed in git-curl-compat.h. These should be easily verifiable against curl's docs/libcurl/symbols-in-version, which is the source of truth for git-curl-compat.h.

This is presented as an alternative to the patch series from brian m. carlson that bumps the minimum version of libcurl to 7.61.0 [3].

-Alejandro

[1] https://lore.kernel.org/git/CAOO-Oz1KhFcyErVx1Qb142PtPJS=UpgSD-FacckqNS4_okAtFQ@mail.gmail.com/ [2] https://lore.kernel.org/git/20241011190812.2654837-1-asedeno@mit.edu/ [3] https://lore.kernel.org/git/20241010235621.738239-1-sandals@crustytoothpaste.net/

Alejandro R. Sedeño (2):
  Conditional use of CURLOPT_PROXYHEADER based on libcurl version
  Fix inconsistencies in git-curl-compat.h
 git-curl-compat.h | 11 +++++++++--
 http.c            |  4 ++++
 2 files changed, 13 insertions(+), 2 deletions(-)
-- 
2.39.5
Next: Alejandro R. Sedeño
Message 1 of 10 in “Restore support for older libcurl and fix some typos”
  1. 0/2 Restore support for older libcurl and fix some typosAlejandro R. Sedeño, Oct 14, 2024
  2. 1/2 Conditional use of CURLOPT_PROXYHEADER based on libcurl versionAlejandro R. Sedeño, Oct 14, 2024
  3. 2/2 Fix inconsistencies in git-curl-compat.hAlejandro R. Sedeño, Oct 14, 2024
  4. Taylor BlauOct 15, 2024
  5. Alejandro R. SedeñoOct 15, 2024
  6. Eric SunshineOct 15, 2024
  7. Taylor BlauOct 15, 2024
  8. Torsten BögershausenOct 17, 2024
  9. Oswald BuddenhagenOct 17, 2024
  10. Torsten BögershausenOct 17, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.