Re: [PATCH 3/3] t1402: exercise disallowed branch names

From: Jeff King <peff@peff.net>
Date: Oct 7, 2024, 20:47 UTC
Message-ID: <20241007204735.GC603285@coredump.intra.peff.net>
In-Reply-To: <8262b81141bbd36cd7a17e6abe5eb6bb688290f3.1728331771.git.code@khaugsbakk.name>

On Mon, Oct 07, 2024 at 10:15:19PM +0200, Kristoffer Haugsbakk wrote:

> Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
> ---

Can we give some more details here? These are cases that already passed before your series, right? At least I'd expect the "HEAD" one to do so, but I guess the "@" fix is new?

I don't need a lengthy explanation, just trying to understand how this change fits into your series. It might be simpler if this came first, adding new tests for existing behavior that was not covered, and then your 2/3 patch just adds the "@" line in the same spot.

-Peff