git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: header signatures for hash transition?

From
Jeff King <peff@peff.net>
Date
Sep 9, 2024, 20:20 UTC
Message-ID
<20240909202058.GA348398@coredump.intra.peff.net>
In-Reply-To
<Zt7Deq2vzZKSTbfU@tapette.crustytoothpaste.net>
On Mon, Sep 09, 2024 at 09:44:26AM +0000, brian m. carlson wrote:
Show 13 quoted lines
> > We still separately find the start of the in-body signature and return a
> > "size_t nonsiglen", though it's a bit awkward (it's counting from the
> > body start, and I am coming from the subject start, but if we assume
> > they're contiguous, it's just a little pointer math). So if this
> > approach is still useful in the long run, I can work around it. But my
> > initial approach (before digging in the history) was to drop the
> > separate buffer, something like the patch below, since it also drops
> > some useless extra copying of the tag contents.
> 
> It was probably that this code was to fix one or more of the
> signature-related atoms in the tests, but I can't speak to it more than
> that.  I trust that you'll make a suitable change that fixes the issue,
> but I'm afraid I can't be more help than that.

OK, thanks. I'll proceed with something like the patch that I showed earlier. It shouldn't change any existing behavior, but I wanted to make sure I wasn't going to make life harder for you in the future.

-Peff
Previous: brian m. carlson
Message 3 of 3 in “header signatures for hash transition?”
  1. Jeff KingSep 8, 2024
  2. brian m. carlsonSep 9, 2024
  3. Jeff KingSep 9, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.