Re: Should Git Tag trailer formatting work?

From: Jeff King <peff@peff.net>
Date: Sep 6, 2024, 21:50 UTC
Message-ID: <20240906215054.GA1149961@coredump.intra.peff.net>
In-Reply-To: <249C7637-0032-4D53-A8A0-83935764334E@alchemists.io>

On Fri, Sep 06, 2024 at 09:22:33AM -0600, Brooke Kuhlmann wrote:

> Yeah, I can render trailer information when using your examples but
> *only* if I disable signing my tags. Here's what my global Git
> configuration looks like:

Ah, OK, that makes sense. We have to parse the trailers from the end, and the parser is not prepared to handle tags' inline signatures (in commits, the signatures are embedded in headers, so the trailer parser doesn't have to worry about them).

I have a rough patch, but it requires making an extra copy of the tag buffer, since the trailer API needs a NUL-terminated string. I'll see if I can clean that up to let us parse it in place, and should send something out in a day or so.

-Peff