Re: [PATCH v2] compat/terminal: mark parameter of git_terminal_prompt() UNUSED

From: Jeff King <peff@peff.net>
Date: Sep 5, 2024, 10:48 UTC
Message-ID: <20240905104812.GA2598693@coredump.intra.peff.net>
In-Reply-To: <ce1c1d66-e0eb-4143-b334-1a83c0492415@ramsayjones.plus.com>

On Sat, Aug 31, 2024 at 03:58:56PM +0100, Ramsay Jones wrote:

> Sorry for being a bit tardy with this, but I'm up-to-my-ears! :)

Well, then I don't feel so bad about being late to respond. :)

> I feel a bit sheepish about taking authorship of this patch, since Jeff
> contributed way more than I did to the text! (I was going to count the
> words to get a better metric, but I have to go out now; if I don't send
> this now it will be tomorrow ...).

This looks great to me, and I think the authorship is fine as it is. The hard part IMHO was finding the problem in the first place!

-Peff