git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/5] dropping some more unused parameters

From
Jeff King <peff@peff.net>
Date
Aug 17, 2024, 07:26 UTC
Message-ID
<20240817072621.GA1535666@coredump.intra.peff.net>

These are from my pile of -Wunused-parameter fixes. The common theme here is that we're actually changing the code rather than just marking parameters with UNUSED. All of them just remove the parameters with the exception of patch 2, where we can actually make use of it (but even that one is not an observable bugfix because all callers were just passing in the_repository anyway).

  [1/5]: refs: drop some unused parameters from create_symref_lock()
  [2/5]: pack-bitmap: load writer config from repository parameter
  [3/5]: pack-bitmap: drop unused parameters from select_pseudo_merges()
  [4/5]: ref-filter: drop unused parameters from email_atom_option_parser()
  [5/5]: diff-lib: drop unused index argument from get_stat_data()
 diff-lib.c           | 9 +++------
 pack-bitmap-write.c  | 4 ++--
 pseudo-merge.c       | 8 ++++----
 pseudo-merge.h       | 6 +++---
 ref-filter.c         | 5 ++---
 refs/files-backend.c | 8 +++-----
 6 files changed, 17 insertions(+), 23 deletions(-)
-Peff
Next: Jeff King
Message 1 of 7 in “dropping some more unused parameters”
  1. 0/5 dropping some more unused parametersJeff King, Aug 17, 2024
  2. 1/5 refs: drop some unused parameters from create_symref_lock()Jeff King, Aug 17, 2024
  3. 2/5 pack-bitmap: load writer config from repository parameterJeff King, Aug 17, 2024
  4. Eric SunshineAug 17, 2024
  5. 3/5 pack-bitmap: drop unused parameters from select_pseudo_merges()Jeff King, Aug 17, 2024
  6. 4/5 ref-filter: drop unused parameters from email_atom_option_parser()Jeff King, Aug 17, 2024
  7. 5/5 diff-lib: drop unused index argument from get_stat_data()Jeff King, Aug 17, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.