git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: quiltimport mode detection oddity

From
AMAndrew Morton <akpm@linux-foundation.org>
Date
Aug 2, 2024, 01:07 UTC
Message-ID
<20240801180706.933d797b0ae5744fdcdf47d2@linux-foundation.org>
In-Reply-To
<xmqqed77hifn.fsf@gitster.g>
On Thu, 01 Aug 2024 17:33:48 -0700 Junio C Hamano <gitster@pobox.com> wrote:
Show 20 quoted lines
> > hp2:/usr/src/mm> git quiltimport --series series
> > tools-separate-out-shared-radix-tree-components.patch
> > warning: tools/testing/radix-tree/generated/autoconf.h has type 100644, expected 100664
> >
> >
> >
> >
> > That patch has
> >
> > diff --git a/tools/testing/radix-tree/generated/autoconf.h a/tools/testing/radix-tree/generated/autoconf.h
> > deleted file mode 100664
> > --- a/tools/testing/radix-tree/generated/autoconf.h
> > +++ /dev/null
> > @@ -1,2 +0,0 @@
> > -#include "bit-length.h"
> > -#define CONFIG_XARRAY_MULTI 1
> 
> So, the patch removes autoconf.h file from that directory.  The
> "extended header" part between "diff --git" and "--- a/..." has
> "deleted file mode 100664" and that is where the warning comes.
yup yup.  The patch says "remove this file which has mode 100664".
The file has mode 100664.
quiltimport says it had mode 100644.  Incorrectly, I suggest.
Previous: Junio C HamanoNext: Jeff King
Message 3 of 10 in “quiltimport mode detection oddity”
  1. Andrew MortonAug 1, 2024
  2. Junio C HamanoAug 2, 2024
  3. Andrew MortonAug 2, 2024
  4. Jeff KingAug 2, 2024
  5. Andrew MortonAug 2, 2024
  6. Junio C HamanoAug 2, 2024
  7. apply: canonicalize modes read from patchesJeff King, Aug 5, 2024
  8. Junio C HamanoAug 15, 2024
  9. t4129: fix racy index when calling chmod after git-addJeff King, Aug 15, 2024
  10. Junio C HamanoAug 15, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.