git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/1] notes: fix editor invocation regression

From
David Disseldorp <ddiss@suse.de>
Date
Jul 29, 2024, 15:13 UTC
Message-ID
<20240729151639.19192-1-ddiss@suse.de>

The following patch attempts to restore previous editor invocation behavior for empty notes, which was inadvertantly changed via 90bc19b3ae (notes.c: introduce '--separator=<paragraph-break>' option, 2023-05-27). A new regression test is included, which passes prior to 90bc19b3ae and after this fix.

Please cc me in any replies as I'm not subscribed.
Cheers, David
--
The following changes since commit ad57f148c6b5f8735b62238dda8f571c582e0e54:
  Git 2.46-rc2 (2024-07-23 16:54:35 -0700)
are available in the Git repository at:
  https://github.com/ddiss/git.git notes_empty_editor_add_v2
for you to fetch changes up to 63019aa2c7bbee5989944a990ca2c0229cef8ae2:
  notes: do not trigger editor when adding an empty note (2024-07-29 13:22:26 +0200)
----------------------------------------------------------------
David Disseldorp (1):
      notes: do not trigger editor when adding an empty note
 builtin/notes.c  | 22 ++++++++++------------
 t/t3301-notes.sh |  5 +++++
 2 files changed, 15 insertions(+), 12 deletions(-)
Next: David Disseldorp
Message 1 of 5 in “notes: fix editor invocation regression”
  1. 0/1 notes: fix editor invocation regressionDavid Disseldorp, Jul 29, 2024
  2. 1/1 notes: do not trigger editor when adding an empty noteDavid Disseldorp, Jul 29, 2024
  3. Junio C HamanoJul 29, 2024
  4. David DisseldorpJul 29, 2024
  5. Junio C HamanoJul 29, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.