git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] notes: fix editor invocation regression

From
David Disseldorp <ddiss@suse.de>
Date
Jul 25, 2024, 14:41 UTC
Message-ID
<20240725144548.3434-1-ddiss@suse.de>

This patchset attempts to revert editor invocation behavior for empty notes, which was inadvertantly changed via 90bc19b3ae ("notes.c: introduce '--separator=<paragraph-break>' option"). The new test passes prior to 90bc19b3ae and after this fix.

Please cc me in any replies as I'm not subscribed.
Cheers, David
--

The following changes since commit ad57f148c6b5f8735b62238dda8f571c582e0e54:

  Git 2.46-rc2 (2024-07-23 16:54:35 -0700)
are available in the Git repository at:
  https://github.com/ddiss/git.git notes_empty_editor_add
for you to fetch changes up to fa40003e560348e146f11aa85ac1fc5a3d86e31e:
  notes: revert note_data.given behavior with empty notes add
(2024-07-25 15:41:56 +0200)
----------------------------------------------------------------
David Disseldorp (2):
      t3301-notes: check editor isn't invoked for empty notes add
      notes: revert note_data.given behavior with empty notes add
 builtin/notes.c  | 5 +++--
 t/t3301-notes.sh | 5 +++++
 2 files changed, 8 insertions(+), 2 deletions(-)
Next: David Disseldorp
Message 1 of 11 in “notes: fix editor invocation regression”
  1. 0/2 notes: fix editor invocation regressionDavid Disseldorp, Jul 25, 2024
  2. 1/2 t3301-notes: check editor isn't invoked for empty notes addDavid Disseldorp, Jul 25, 2024
  3. Kristoffer HaugsbakkJul 25, 2024
  4. David DisseldorpJul 25, 2024
  5. Junio C HamanoJul 25, 2024
  6. Junio C HamanoJul 25, 2024
  7. David DisseldorpJul 25, 2024
  8. 2/2 notes: revert note_data.given behavior with empty notes addDavid Disseldorp, Jul 25, 2024
  9. Junio C HamanoJul 25, 2024
  10. Kristoffer HaugsbakkJul 25, 2024
  11. David DisseldorpJul 25, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.