git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3 0/1] parse-options: localize mark-up of placeholder text in the short help

From
Alexander Shopov <ash@kambanaria.org>
Date
Jul 7, 2024, 15:35 UTC
Message-ID
<20240707153526.97984-1-ash@kambanaria.org>
In-Reply-To
<xmqqttij86lc.fsf@gitster.g>
Hi Junio & Jiang,
I am submitting the patch taking into account the feedback you gave last time.
Just to quickly remind: this allows translatability of "<>" chars in:
  OPT_STRING(0, "author", &force_author, N_("author"), N_("override author")),
displayed as:
    --[no-]author <author>    override author
@Junio:
> ... above explanation ... should replace ... log message
Done
> The explanation after "such as:" needs improvement...
Improved and closely follows your suggestion
> user's language may use a convention different from ... [square brackets]
> ... to mark an optional part ...
I decided againgst implementing this:
 - None of the translators have indicated such a need and adding it makes
   the whole thing more error prone
 - There is a tiny difference from what I did with the placeholder characters:
   I am actually skipping the characters in the Bulgarian translation (rather than 
   substituting them) which leads to shorter but still clear messages.  Skipping 
   both "[]" and "<>" and will lead to confusion.  "[]" are not as dangerous as
   "<>" for shell
 - If translators actually request it - it can be implemented when the real need
   arises
@Jiang
> ... with only one commit... not necessary to ... provide a cover letter

I agree but I am using the cover letter to remind what this is all about and point what I have done with the code revew. You can't remember all interactions.

> ... people don't like the markers ... "<" and ">" ... have special
> meanings ... in shell programming 
I have added something to this meaning in the log message.

Kind regards: al_shopov

Alexander Shopov (1):
  parse-options: localize mark-up of placeholder text in the short help
 parse-options.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
-- 
2.45.2
Previous: Junio C HamanoNext: Alexander Shopov
Message 9 of 16 in “[RESUBMIT 2nd] Consistency for substitution hints (i18n) 0/1]”
  1. [RESUBMIT 2nd] Consistency for substitution hints (i18n) 0/1]Alexander Shopov, Apr 21, 2024
  2. [RESUBMIT 2nd] Consistency for substitution hints (i18n) 1/1] parse-options: use localized substitution hintsAlexander Shopov, Apr 21, 2024
  3. Junio C HamanoApr 21, 2024
  4. 0/1 Allowing localized substitution hints in parse-optionsAlexander Shopov, May 25, 2024
  5. Junio C HamanoMay 27, 2024
  6. Jiang XinMay 28, 2024
  7. 1/1 parse-options: allow localized substitution hints in macrosAlexander Shopov, May 25, 2024
  8. Junio C HamanoMay 27, 2024
  9. 0/1 parse-options: localize mark-up of placeholder text in the short helpAlexander Shopov, Jul 7, 2024
  10. 1/1 parse-options: localize mark-up of placeholder text in the short helpAlexander Shopov, Jul 7, 2024
  11. Alexander ShopovJul 14, 2024
  12. Junio C HamanoJul 15, 2024
  13. 0/1 Localize mark-up of placeholder text in the short helpAlexander Shopov, Dec 28, 2024
  14. 1/1 parse-options: localize mark-up of placeholder text in the short helpAlexander Shopov, Dec 28, 2024
  15. Junio C HamanoDec 28, 2024
  16. Jiang XinDec 30, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.