[PATCH] object-file: fix leak on conversion failure
- From
- Eric Wong <e@80x24.org>
- Date
- Jun 22, 2024, 04:36 UTC
- Message-ID
- <20240622043648.M78681@dcvr>
I'm not sure exactly how to trigger the leak, but it seems fairly obvious that the `content' buffer should be freed even if convert_object_file() fails. Noticed while working in this area on unrelated things.
Signed-off-by: Eric Wong <e@80x24.org> --- object-file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/object-file.c b/object-file.c index d3cf4b8b2e..00c8f1039b 100644 --- a/object-file.c +++ b/object-file.c @@ -1711,9 +1711,9 @@ static int oid_object_info_convert(struct repository *r, ret = convert_object_file(&outbuf, the_hash_algo, input_algo, content, size, type, !do_die); + free(content); if (ret == -1) return -1; - free(content); size = outbuf.len; content = strbuf_detach(&outbuf, NULL); }