Re: [PATCH 0/2] Revert defense-in-depth patches breaking Git LFS

From: Jeff King <peff@peff.net>
Date: May 30, 2024, 08:17 UTC
Message-ID: <20240530081725.GH1949834@coredump.intra.peff.net>
In-Reply-To: <1cbdeb41-2ad3-05e4-ab27-1f84086b7f43@gmx.de>

On Wed, May 29, 2024 at 02:17:41PM +0200, Johannes Schindelin wrote:

Show 7 quoted lines

> On Wed, 29 May 2024, Jeff King wrote:
> 
> > [...] But of course most sites just use the defaults, so all warnings
> > are effectively errors.
> 
> I wish that had been pointed out on the git-security mailing list when I
> offered this patch up for review.

Me too. But I agree with everything Junio already responded here.

Show 5 quoted lines

> So this is what the fix-up patch would look like to make the code match my
> intention:
> 
> -- snipsnap --
> Subject: [PATCH] fsck: demote the newly-introduced symlink issues from WARN -> IGNORE

I think you mean s/IGNORE/INFO/ here and elsewhere in the commit message? The actual code change looks correct.

-Peff