Re: [PATCH v2 0/8] midx-write: miscellaneous clean-ups for incremental MIDXs

From: Jeff King <peff@peff.net>
Date: May 30, 2024, 07:14 UTC
Message-ID: <20240530071432.GD1949834@coredump.intra.peff.net>
In-Reply-To: <cover.1717023301.git.me@ttaylorr.com>

On Wed, May 29, 2024 at 06:55:15PM -0400, Taylor Blau wrote:

> This is a small reroll of my series which has a grab-bag of midx-write
> related cleanups that I pulled out of a larger series to implement
> incremental MIDX chains.

These all look pretty reasonable to me. Thanks for breaking them off of the larger series. I think it's generally nice to get things in smaller chunks.

Sometimes it is a little tough to evaluate refactorings without seeing the larger context in which they'd be used. But all of these were either immediate improvements, or didn't take much imagination to see where they'd make later things easier.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.