git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 03/12] ci: drop mention of BREW_INSTALL_PACKAGES variable

From
Junio C Hamano <gitster@pobox.com>
Date
May 24, 2024, 19:47 UTC
Message-ID
<20240524194715.695916-4-gitster@pobox.com>
In-Reply-To
<20240524194715.695916-1-gitster@pobox.com>
From: Jeff King <peff@peff.net>

The last user of this variable went away in 4a6e4b9602 (CI: remove Travis CI support, 2021-11-23), so it's doing nothing except making it more confusing to find out which packages _are_ installed.

[jc: cherry-picked from v2.45.0-1-g9d4453e8d6]
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 ci/install-dependencies.sh | 2 --
 1 file changed, 2 deletions(-)
diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
index 4f407530d3..33039d516b 100755
--- a/ci/install-dependencies.sh
+++ b/ci/install-dependencies.sh
@@ -34,8 +34,6 @@ macos-*)
 	export HOMEBREW_NO_AUTO_UPDATE=1 HOMEBREW_NO_INSTALL_CLEANUP=1
 	# Uncomment this if you want to run perf tests:
 	# brew install gnu-time
-	test -z "$BREW_INSTALL_PACKAGES" ||
-	brew install $BREW_INSTALL_PACKAGES
 	brew link --force gettext
 	mkdir -p $HOME/bin
 	(
-- 
2.45.1-246-gb9cfe4845c
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 13 in “Fix various overly aggressive protections in 2.45.1 and friends”
  1. 00/12 Fix various overly aggressive protections in 2.45.1 and friendsJunio C Hamano, May 24, 2024
  2. 01/12 send-email: drop FakeTerm hackJunio C Hamano, May 24, 2024
  3. 02/12 send-email: avoid creating more than one Term::ReadLine objectJunio C Hamano, May 24, 2024
  4. 03/12 ci: drop mention of BREW_INSTALL_PACKAGES variableJunio C Hamano, May 24, 2024
  5. 04/12 ci: avoid bare "gcc" for osx-gcc jobJunio C Hamano, May 24, 2024
  6. 05/12 ci: stop installing "gcc-13" for osx-gccJunio C Hamano, May 24, 2024
  7. 06/12 hook: plug a new memory leakJunio C Hamano, May 24, 2024
  8. 07/12 init: use the correct path of the templates directory againJunio C Hamano, May 24, 2024
  9. 08/12 Revert "core.hooksPath: add some protection while cloning"Junio C Hamano, May 24, 2024
  10. 09/12 tests: verify that `clone -c core.hooksPath=/dev/null` works againJunio C Hamano, May 24, 2024
  11. 10/12 clone: drop the protections where hooks aren't runJunio C Hamano, May 24, 2024
  12. 11/12 Revert "Add a helper function to compare file contents"Junio C Hamano, May 24, 2024
  13. 12/12 Revert "fsck: warn about symlink pointing inside a gitdir"Junio C Hamano, May 24, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.