Re: [PATCH] trace2: intercept all common signals

From: Jeff King <peff@peff.net>
Date: May 10, 2024, 20:05 UTC
Message-ID: <20240510200522.GD1954863@coredump.intra.peff.net>
In-Reply-To: <CAJoAoZkXTo69AiowTVFvKyZBCo2B73hPp2ys+oZyOLU5qxAgFw@mail.gmail.com>

On Fri, May 10, 2024 at 12:49:06PM -0700, Emily Shaffer wrote:

Show 9 quoted lines

> > We have test_match_signal(). Unfortunately it's not integrated with
> > test_expect_code(), so you have to do:
> >
> >   { thing_which_fails; OUT=$?; } &&
> >   test_match_signal 15 "$OUT"
> 
> Right, what I meant above is that `15` isn't portable, I'd have to get
> the correct int value of SIGINT/SIGSEGV from some other shell utility
> at test time.

Yes, but we already rely on it elsewhere (like t0005), and the idea of test_match_signal is that it would convert from "standard" numbers to something platform specific. Though aside from Windows (where the signal number is sometimes lost entirely) we've never had to actually do such conversion so far; "15" really is standard.

If your primary concern, though, is the trace2 output and not the exit code of the program, then it may not be worth worrying too much about.

-Peff