Re: t4216-log-bloom.sh broken ?

From: Torsten Bögershausen <tboegi@web.de>
Date: May 2, 2024, 20:51 UTC
Message-ID: <20240502205121.GB11895@tb-raspi4>
In-Reply-To: <xmqqsez0c6ma.fsf@gitster.g>

On Thu, May 02, 2024 at 01:15:57PM -0700, Junio C Hamano wrote:

Show 7 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
> > I am curious what other differences Torsten will find out between
> > good macs and bad ones.  Perhaps we can narrow down the bad apples?
>
> So, "no, your 'mv' is broken" seems to be the answer to the question
> on the Subject line, and it is rather well-known, it seems.

[]

>  		"$@" <"$fn" >"$fn.tmp" &&
> -	mv "$fn.tmp" "$fn"
> +	# some vintages of macOS 'mv' fails to overwrite a read-only file.
> +	mv -f "$fn.tmp" "$fn"

Thanks folks for digging - the patch makes both test cases pass. Some official information:

$ man mv

on the both machines says [snip] If the destination path does not have a mode which permits writing, mv prompts the user for confirmation as specified for the -i option.

To summarize what I have at hand right now: MacOs 11.7.10 fails t4216 and t5318, both pass under MacOs 13.6.6

But why doesn't `mv` not hang then ?