git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] doc: clarify practices for submitting updated patch versions

From
RHRoland Hieber <rohieb+git@rohieb.name>
Date
Apr 26, 2024, 09:31 UTC
Message-ID
<20240426093110.3lxbmhwfl3efwo2s@glados>
In-Reply-To
<20240425213404.133660-1-jltobler@gmail.com>
On Thu, Apr 25, 2024 at 04:34:04PM -0500, Justin Tobler wrote:
Show 6 quoted lines
> The `SubmittingPatches` documentation briefly mentions that related
> patches should be grouped together in their own e-mail thread. Expand on
> this to explicitly state that updated versions of a patch series should
> also follow this. Also provide add a link to existing documentation from
> `MyFirstContribution` that provides detailed instructions on how to do
> this via `git-send-email(1)`.

Thankst! I obviously didn't read the old text in the intended way when I submitted my patch iterations yesterday, so your patch makes it much more clear!

 - Roland
Show 31 quoted lines
> Signed-off-by: Justin Tobler <jltobler@gmail.com>
> ---
>  Documentation/SubmittingPatches | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index c647c7e1b4..bc212836f9 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -415,10 +415,12 @@ e-mail tools, so that they may comment on specific portions of
>  your code.  For this reason, each patch should be submitted
>  "inline" in a separate message.
>  
> -Multiple related patches should be grouped into their own e-mail
> -thread to help readers find all parts of the series.  To that end,
> -send them as replies to either an additional "cover letter" message
> -(see below), the first patch, or the respective preceding patch.
> +All subsequent versions of a patch series and other related patches should be
> +grouped into their own e-mail thread to help readers find all parts of the
> +series.  To that end, send them as replies to either an additional "cover
> +letter" message (see below), the first patch, or the respective preceding patch.
> +Here is a link:MyFirstContribution.html#v2-git-send-email[step-by-step guide] on
> +how to submit updated versions of a patch series.
>  
>  If your log message (including your name on the
>  `Signed-off-by` trailer) is not writable in ASCII, make sure that
> 
> base-commit: e326e520101dcf43a0499c3adc2df7eca30add2d
> -- 
> 2.44.0
> 
-- 
Roland Hieber
E-Mail: rohieb@rohieb.name
Web: https://rohieb.name
PGP Fingerprint: 3B7A C587 9464 CAB6 5B90  7151 B241 3C66 DD2C 3FEA
Previous: Justin ToblerNext: Karthik Nayak
Message 2 of 3 in “doc: clarify practices for submitting updated patch versions”
  1. doc: clarify practices for submitting updated patch versionsJustin Tobler, Apr 25, 2024
  2. Roland HieberApr 26, 2024
  3. Karthik NayakApr 26, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.