git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/4] upload-pack: support a missing-action

From
Christian Couder <christian.couder@gmail.com>
Date
Apr 18, 2024, 18:40 UTC
Message-ID
<20240418184043.2900955-1-christian.couder@gmail.com>

`git pack-objects` already supports a `--missing=<missing-action>` option, so that it can avoid erroring out if some objects aren't available.

It is interesting to have `git upload-pack` support a similar way to avoid sending some objects in case they aren't available on the server.

For example, in case both the server and the client are using a separate promisor remote that contain some objects, it can be better if the server doesn't try to send such objects back to the client, but instead let the client get those objects separately from the promisor remote. (The client needs to have the separate promisor remote configured, for that to work.)

Another example could be a server where some objects have been corrupted or deleted. It could still be useful for clients who could get those objects from another source, like perhaps a different client, to be able to fetch or clone from the server.

As `git rev-list` also supports a `--missing=<missing-action>` option, the first 3 patches in this series are about refactoring related code from both `git rev-list` and `git pack-objects` into new "missing.{c,h}" files. Patch 4/4 then adds a new `uploadpack.missingAction` configuration variable.

Christian Couder (4):
  rev-list: refactor --missing=<missing-action>
  missing: support rejecting --missing=print
  pack-objects: use the missing action API
  upload-pack: allow configuring a missing-action
 Documentation/config/uploadpack.txt |   9 ++
 Makefile                            |   1 +
 builtin/pack-objects.c              |  46 +++++-----
 builtin/rev-list.c                  |  41 ++-------
 missing.c                           |  42 ++++++++++
 missing.h                           |  20 +++++
 t/t5706-upload-pack-missing.sh      | 125 ++++++++++++++++++++++++++++
 upload-pack.c                       |  19 +++++
 8 files changed, 244 insertions(+), 59 deletions(-)
 create mode 100644 missing.c
 create mode 100644 missing.h
 create mode 100755 t/t5706-upload-pack-missing.sh
-- 
2.44.0.655.g111bceeb19
Next: Christian Couder
Message 1 of 13 in “upload-pack: support a missing-action”
  1. 0/4 upload-pack: support a missing-actionChristian Couder, Apr 18, 2024
  2. 1/4 rev-list: refactor --missing=<missing-action>Christian Couder, Apr 18, 2024
  3. Junio C HamanoApr 18, 2024
  4. 2/4 missing: support rejecting --missing=printChristian Couder, Apr 18, 2024
  5. Junio C HamanoApr 18, 2024
  6. 3/4 pack-objects: use the missing action APIChristian Couder, Apr 18, 2024
  7. 4/4 upload-pack: allow configuring a missing-actionChristian Couder, Apr 18, 2024
  8. Junio C HamanoApr 18, 2024
  9. 0/3 upload-pack: support a missing-actionChristian Couder, May 24, 2024
  10. 1/3 rev-list: refactor --missing=<missing-action>Christian Couder, May 24, 2024
  11. 2/3 pack-objects: use the missing action APIChristian Couder, May 24, 2024
  12. 3/3 upload-pack: allow configuring a missing-actionChristian Couder, May 24, 2024
  13. Junio C HamanoMay 24, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.