Re: [RFC][PATCH] t-prio-queue: simplify using compound literals

> Am 02.04.24 um 22:41 schrieb Jeff King:
> >
> > I don't have a
> > strong opinion on compound literals in general, but if we did allow
> > them, we could clean up the horrible non-reentrant DATE_MODE().
> 
> We can easily make them reentrant without compound literals.  It just
> requires simple changes to lots of places.  Patch below.
> 
> --- >8 ---
> Subject: [PATCH] date: make DATE_MODE thread-safe
> 
> date_mode_from_type() modifies a static variable and returns a pointer
> to it.  This is not thread-safe.  Most callers of date_mode_from_type()
> use it via the macro DATE_MODE and pass its result on to functions like
> show_date(), which take a const pointer and don't modify the struct.
> 
> Avoid the static storage by putting the variable on the stack and
> returning the whole struct date_mode.  Change functions that take a
> constant pointer to expect the whole struct instead.