git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] completion: fix prompt with unset SHOWCONFLICTSTATE in nounset mode

From
Ville Skyttä <ville.skytta@iki.fi>
Date
Apr 1, 2024, 11:30 UTC
Message-ID
<20240401113033.28709-1-ville.skytta@iki.fi>

`GIT_PS1_SHOWCONFLICTSTATE` is a user variable that might not be set, causing errors when the shell is in `nounset` mode.

Take into account on access by falling back to an empty string.
Signed-off-by: Ville Skyttä <ville.skytta@iki.fi>
---
 contrib/completion/git-prompt.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/completion/git-prompt.sh b/contrib/completion/git-prompt.sh
index 71f179cba3..3826f52dec 100644
--- a/contrib/completion/git-prompt.sh
+++ b/contrib/completion/git-prompt.sh
@@ -528,7 +528,7 @@ __git_ps1 ()
 	fi
 
 	local conflict="" # state indicator for unresolved conflicts
-	if [[ "${GIT_PS1_SHOWCONFLICTSTATE}" == "yes" ]] &&
+	if [[ "${GIT_PS1_SHOWCONFLICTSTATE-}" == "yes" ]] &&
 	   [[ $(git ls-files --unmerged 2>/dev/null) ]]; then
 		conflict="|CONFLICT"
 	fi
-- 
2.40.1
Next: Junio C Hamano
Message 1 of 6 in “completion: fix prompt with unset SHOWCONFLICTSTATE in nounset mode”
  1. completion: fix prompt with unset SHOWCONFLICTSTATE in nounset modeVille Skyttä, Apr 1, 2024
  2. Junio C HamanoApr 1, 2024
  3. Ville SkyttäApr 1, 2024
  4. Junio C HamanoApr 1, 2024
  5. Ville SkyttäApr 1, 2024
  6. Junio C HamanoApr 1, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.