Re: [PATCH 00/11] midx: split MIDX writing routines into midx-write.c, cleanup

From: Jeff King <peff@peff.net>
Date: Mar 27, 2024, 08:39 UTC
Message-ID: <20240327083911.GD830163@coredump.intra.peff.net>
In-Reply-To: <cover.1711387439.git.me@ttaylorr.com>

On Mon, Mar 25, 2024 at 01:24:11PM -0400, Taylor Blau wrote:

Show 11 quoted lines

> This is a small-ish series that I worked on to split the functions from
> midx.c which are responsible for writing MIDX files into a separate
> compilation unit, midx-write.c.
> 
> This is done for a couple of reasons:
> 
>   - It reduces the size of midx.c, which is already quite large, thus
>     making it easier to read.
> 
>   - It more clearly separates responsibility between the two, similar to
>     the division between pack-bitmap.c, and pack-bitmap-write.c.

Yeah, I think this is a good cleanup. Like Junio, I did wonder about the piece-meal movement. I kind of wonder if one big patch moving everything would have been just as easy to review. But I'm happy either way.

The other refactoring patches all looked good to me.

-Peff