git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v1 2/4] builtin/receive-pack.c: change xwrite to write_in_full to allow large sizes.

From
RBRandall S. Becker <the.n.e.key@gmail.com>
Date
Feb 26, 2024, 22:05 UTC
Message-ID
<20240226220539.3494-3-randall.becker@nexbridge.ca>
In-Reply-To
<20240226220539.3494-1-randall.becker@nexbridge.ca>
From: "Randall S. Becker" <rsbecker@nexbridge.com>

This change is required because some platforms do not support file writes of arbitrary sizes (e.g, NonStop). xwrite ends up truncating the output to the maximum single I/O size possible for the destination device.

Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
---
 builtin/receive-pack.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index db65607485..5064f3d300 100644
--- a/builtin/receive-pack.c
+++ b/builtin/receive-pack.c
@@ -455,8 +455,9 @@ static void report_message(const char *prefix, const char *err, va_list params)
 
 	if (use_sideband)
 		send_sideband(1, 2, msg, sz, use_sideband);
-	else
-		xwrite(2, msg, sz);
+	else {
+		write_in_full(2, msg, sz);
+	}
 }
 
 __attribute__((format (printf, 1, 2)))
-- 
2.42.1
Previous: rsbecker@nexbridge.comNext: rsbecker@nexbridge.com
Message 8 of 18 in “Change xwrite() to write_in_full() in builtins.”
  1. 0/4 Change xwrite() to write_in_full() in builtins.Randall S. Becker, Feb 26, 2024
  2. 1/4 builtin/index-pack.c: change xwrite to write_in_full to allow large sizes.Randall S. Becker, Feb 26, 2024
  3. Taylor BlauFeb 26, 2024
  4. rsbecker@nexbridge.comFeb 26, 2024
  5. Junio C HamanoFeb 26, 2024
  6. rsbecker@nexbridge.comFeb 27, 2024
  7. rsbecker@nexbridge.comFeb 26, 2024
  8. 2/4 builtin/receive-pack.c: change xwrite to write_in_full to allow large sizes.Randall S. Becker, Feb 26, 2024
  9. rsbecker@nexbridge.comFeb 26, 2024
  10. Junio C HamanoFeb 26, 2024
  11. rsbecker@nexbridge.comFeb 27, 2024
  12. 3/4 builtin/repack.c: change xwrite to write_in_full to allow large sizes.Randall S. Becker, Feb 26, 2024
  13. Junio C HamanoFeb 26, 2024
  14. Jeff KingFeb 27, 2024
  15. Jeff KingFeb 27, 2024
  16. 4/4 builtin/unpack-objects.c: change xwrite to write_in_full to allow large sizes.Randall S. Becker, Feb 26, 2024
  17. Junio C HamanoFeb 26, 2024
  18. rsbecker@nexbridge.comFeb 27, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.