[PATCH v2 1/4] revision: clarify a 'return NULL' in get_reference()
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Feb 8, 2024, 13:50 UTC
- Message-ID
- <20240208135055.2705260-2-christian.couder@gmail.com>
- In-Reply-To
- <20240208135055.2705260-1-christian.couder@gmail.com>
In general when we know a pointer variable is NULL, it's clearer to explicitly return NULL than to return that variable.
In get_reference() when 'object' is NULL, we already return NULL when 'revs->exclude_promisor_objects && is_promisor_object(oid)' is true, but we return 'object' when 'revs->ignore_missing' is true.
Let's make the code clearer and more uniform by also explicitly returning NULL when 'revs->ignore_missing' is true.
Helped-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Christian Couder <chriscool@tuxfamily.org> --- revision.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/revision.c b/revision.c index 2424c9bd67..4c5cd7c3ce 100644 --- a/revision.c +++ b/revision.c @@ -385,7 +385,7 @@ static struct object *get_reference(struct rev_info *revs, const char *name, if (!object) { if (revs->ignore_missing) - return object; + return NULL; if (revs->exclude_promisor_objects && is_promisor_object(oid)) return NULL; die("bad object %s", name);
-- 2.43.0.565.g97b5fd12a3.dirty