Re: [PATCH 1/2] t9902: verify that completion does not print anything

From: Jeff King <peff@peff.net>
Date: Jan 12, 2024, 15:16 UTC
Message-ID: <20240112151655.GA640039@coredump.intra.peff.net>
In-Reply-To: <27edf445-d7fa-7aaf-7682-4ecc03366ef0@gmx.de>

On Fri, Jan 12, 2024 at 02:12:43PM +0100, Johannes Schindelin wrote:

> But my main concern is: Why does this happen in the first place? If we are
> running with Bash, why does `BASH_XTRACEFD` to work as intended here and
> makes it necessary to filter out the traced commands?

BASH_XTRACEFD was introduced in bash 4.1. macOS ships with the ancient bash 3.2.57, which is the last GPLv2 version.

One simple solution is to mark the script with test_untraceable. See 5fc98e79fc (t: add means to disable '-x' tracing for individual test scripts, 2018-02-24) and 5827506928 (t1510-repo-setup: mark as untraceable with '-x', 2018-02-24).

That will disable tracing entirely in the script for older versions of bash, which could make debugging harder. But it will still work as expected for people on reasonable versions of bash, and doesn't introduce any complicated code.

-Peff