git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] push: region_leave trace for negotiate_using_fetch

From
SDSam Delmerico <delmerico@google.com>
Date
Jan 3, 2024, 22:40 UTC
Message-ID
<20240103224054.1940209-1-delmerico@google.com>

There were two region_enter events for negotiate_using_fetch instead of one enter and one leave. This commit replaces the second region_enter event with a region_leave.

Signed-off-by: Sam Delmerico <delmerico@google.com>
---
 fetch-pack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fetch-pack.c b/fetch-pack.c
index 31a72d43de..dba6d79944 100644
--- a/fetch-pack.c
+++ b/fetch-pack.c
@@ -2218,7 +2218,7 @@ void negotiate_using_fetch(const struct oid_array *negotiation_tips,
 					   the_repository, "%d",
 					   negotiation_round);
 	}
-	trace2_region_enter("fetch-pack", "negotiate_using_fetch", the_repository);
+	trace2_region_leave("fetch-pack", "negotiate_using_fetch", the_repository);
 	trace2_data_intmax("negotiate_using_fetch", the_repository,
 			   "total_rounds", negotiation_round);
 	clear_common_flag(acked_commits);

base-commit: a26002b62827b89a19b1084bd75d9371d565d03c
-- 
2.43.0.472.g3155946c3a-goog
Next: Junio C Hamano
Message 1 of 4 in “push: region_leave trace for negotiate_using_fetch”
  1. push: region_leave trace for negotiate_using_fetchSam Delmerico, Jan 3, 2024
  2. Junio C HamanoJan 3, 2024
  3. Sam DelmericoJan 5, 2024
  4. Junio C HamanoJan 5, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.