git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Why is `revert` undocumented in interactive rebase todo help?

From
Michael Lohmann <mial.lohmann@gmail.com>
Date
Dec 18, 2023, 06:53 UTC
Message-ID
<20231218065313.55725-1-mi.al.lohmann@gmail.com>

Hi! I wanted to align rebase and revert/cherry-pick a bit more (for the latter I am currently finishing my patch for --show-current-patch and then looked into possibly implementing --edit-todo). To avoid code duplication I wanted to reuse the existing interactive-rebase code as much as possible and ended up at the todo script parsing in the sequencer. I was a bit surprised to find that the file could already handle the command `revert`, even though it isn't documented in `append_todo_help` of rebase-interactive.c - is that by choice or just missing documentation?

Whenever I wanted to achieve this I used `break` and then manually did the revert, which obviously works fine, but it is much nicer to put the command in the todo file... (Now that I think about it I could also have done it with `exec`, but that is also not the nicest solution :D ). The only other command not mentioned is `noop` which is obviously not too useful apart from distinguishing an empty list and aborting, so I totally understand it missing.

Yes - in contrast to all the other options it does not have a single char notation (and 'r' is obviously already taken und 'u' for undo as well or 't' for the last letter), but why not show it in the list without it? Or maybe add 'v' for "reVert"?

Cheers Michael

P.S.: @Johannes Schindelin I saw your work of making the todo files in the sequencer more reusable and the many reworks/improvements, so I added you in cc - I hope that was alright (otherwise I'll buy you a Kölsch as an apology ;) )...

Next: Johannes Schindelin
Message 1 of 8 in “Why is `revert` undocumented in interactive rebase todo help?”
  1. Michael LohmannDec 18, 2023
  2. Johannes SchindelinDec 18, 2023
  3. rebase-interactive: show revert option and add single letter shortcutMichael Lohmann, Dec 18, 2023
  4. Phillip WoodDec 18, 2023
  5. rebase-interactive: show revert option and add single letter shortcutMichael Lohmann, Dec 18, 2023
  6. Michael LohmannDec 18, 2023
  7. Junio C HamanoDec 18, 2023
  8. Michael LohmannDec 20, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.