Re: [PATCH 2/9] for-each-ref: clarify interaction of --omit-empty & --count

From: Øystein Walle <oystwa@gmail.com>
Date: Nov 7, 2023, 19:23 UTC
Message-ID: <20231107192326.48296-1-oystwa@gmail.com>
In-Reply-To: <88eba4146cd250fcabfb9ffa9b410ce912a82ce7.1699320362.git.gitgitgadget@gmail.com>

Hi Victoria,

Victoria Dye <vdye@github.com> writes:

Show 5 quoted lines

> Update the 'for-each-ref' builtin documentation to clarify that refs
> "omitted" by --omit-empty are still counted toward the limit specified
> by --count. The use of the term "omit" would otherwise be somewhat
> ambiguous and could incorrectly be construed as excluding empty refs
> entirely (i.e. not counting them towards the total ref count).

I implemented --omit-empty and I completely overlooked --count!

(If I were to do it all over again I probably would have implemented it so that so-called omitted refs did not count towards the total. It makes sense to me since e.g. `git log -3 -- git.c` prints the three most recent commits that touch git.c regardless of how many commits were walked in the process.)

This is a good and welcome clarification.

Acked-by: Øystein Walle <oystwa@gmail.com>