Re: please add link / url to remote - when - git push
On Mon, Oct 30, 2023 at 05:39:19AM -0400, Jeff King wrote:
Show 28 quoted lines
> On Mon, Oct 30, 2023 at 10:30:23AM +0100, Michal Suchánek wrote:
>
> > > > On the other hand, option to NOT display those remote messages is also
> > > > missing. At least with git 2.35 they are displayed even when -q argument
> > > > is given.
> > >
> > > That is also up to GitHub to fix on the server side:
> > >
> > > https://lore.kernel.org/git/20230519090559.GA3515410@coredump.intra.peff.net/
> >
> > If the server did not reject the push the messages it returns could be
> > considered informational.
>
> Hmm, yeah, I could perhaps buy that line of argument. Though it's
> possible they are "warnings" of the sort that should still be emitted
> with "--quiet"; really only the server knows. And note that even "reject
> the push" is not necessarily all-or-nothing. The server may accept some
> subset of the refs.
>
> But...
>
> > Not sure if the final status of the push is available or of the
> > rejection is only noted in these messages, though.
>
> Yes, this is a problem. Those messages are streamed out as we receive
> them from the server, and before we get any status report back. I don't
> think we'd want to buffer them, as they can be arbitrarily large (and
> may even be progress reports that are meant to be shown in real-time).
Not when the user asked to not show progress.
Thanks
Michal