git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH] Not computing changed path filter for root commits

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Oct 9, 2023, 20:59 UTC
Message-ID
<20231009205925.1915096-1-jonathantanmy@google.com>
In-Reply-To
<ZSQ3s3ZiRcvQIKOa@nand.local>
Taylor Blau <me@ttaylorr.com> writes:
Show 22 quoted lines
> This only happens when we return REV_TREE_NEW from a call to
> `rev_compare_tree(revs, p, commit, nth_parent)`. But we'll only get
> REV_TREE_NEW back if
> 
>     repo_get_commit_tree(the_repository, p);
> 
> returns NULL. But when we call rev_same_tree_as_empty(revs, p) in the
> REV_TREE_NEW case, we return early as follows:
> 
>     struct tree *t1 = repo_get_commit_tree(revs, p);
>     if (!t1)
>       return 0;
> 
> So we won't even consult the Bloom filter in that case, since t1 is NULL
> for the same reason as what caused rev_compare_tree() to return
> REV_TREE_NEW in the first place.
> 
> I am still dumbfounded by how we would ever get REV_TREE_NEW in the
> first place, but if we did, I think we would be OK here.
> 
> Thanks,
> Taylor

Ah, good point. Your patch in https://lore.kernel.org/git/ZQnmTXUO94%2FQy8mq@nand.local/ looks good to me, then.

Previous: Taylor BlauNext: Taylor Blau
Message 8 of 10 in “Not computing changed path filter for root commits”
  1. Not computing changed path filter for root commitsJonathan Tan, Sep 11, 2023
  2. Junio C HamanoSep 15, 2023
  3. SZEDER GáborSep 15, 2023
  4. Taylor BlauSep 19, 2023
  5. Jonathan TanOct 2, 2023
  6. Taylor BlauOct 9, 2023
  7. Taylor BlauOct 9, 2023
  8. Jonathan TanOct 9, 2023
  9. Taylor BlauOct 10, 2023
  10. Taylor BlauSep 19, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.