[PATCH] repack: free existing_cruft array after use
- From
Jeff King <peff@peff.net>
- Date
- Oct 7, 2023, 17:20 UTC
- Message-ID
- <20231007172031.GA1524950@coredump.intra.peff.net>
- In-Reply-To
- <e7beb2060dad648ec5c3fa8984e432ee243ae012.1696293862.git.me@ttaylorr.com>
On Mon, Oct 02, 2023 at 08:44:32PM -0400, Taylor Blau wrote:
Show 9 quoted lines
> +static void collapse_small_cruft_packs(FILE *in, size_t max_size,
> + struct existing_packs *existing)
> +{
> + struct packed_git **existing_cruft, *p;
> + struct strbuf buf = STRBUF_INIT;
> [...]
> +
> + strbuf_release(&buf);
> +}Coverity (using the just-merged-to-next version of the workflow file!) flagged a leak here. Since the topic (tb/repack-max-cruft-size) is in 'next', I think we'd want this on top:
-- >8 -- Subject: [PATCH] repack: free existing_cruft array after use
We allocate an array of packed_git pointers so that we can sort the list of cruft packs, but we never free the array, causing a small leak. Note that we don't need to free the packed_git structs themselves; they're owned by the repository object.
Signed-off-by: Jeff King <peff@peff.net> --- builtin/repack.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/builtin/repack.c b/builtin/repack.c index a1a893d952..69e8f302c0 100644 --- a/builtin/repack.c +++ b/builtin/repack.c @@ -955,6 +955,7 @@ static void collapse_small_cruft_packs(FILE *in, size_t max_size, existing->non_kept_packs.items[i].string); strbuf_release(&buf); + free(existing_cruft); } static int write_cruft_pack(const struct pack_objects_args *args,
-- 2.42.0.884.gc318dcfe19