git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] a few more leak fixes

From
Jeff King <peff@peff.net>
Date
Oct 5, 2023, 21:28 UTC
Message-ID
<20231005212802.GA982892@coredump.intra.peff.net>

I was really bothered that using clang with SANITIZE=leak found a leak that gcc didn't. And then I was doubly bothered to find that there is one that gcc finds that clang doesn't!

I don't think either of these are urgent or important leaks on their own, but the flaky nature of the results makes it annoying while trying to find and clean up other leaks. So here are some fixes. Patches 1 and 3 are those two cases, respectively. Patch 2 is a more interesting leak-fix enabled by the infrastructure added in patch 1.

  [1/3]: decorate: add clear_decoration() function
  [2/3]: revision: clear decoration structs during release_revisions()
  [3/3]: daemon: free listen_addr before returning
 daemon.c                         | 37 ++++++++++++++++++--------------
 decorate.c                       | 15 +++++++++++++
 decorate.h                       | 10 +++++++++
 line-log.c                       | 10 +++++++++
 line-log.h                       |  2 ++
 revision.c                       |  9 ++++++++
 t/helper/test-example-decorate.c |  2 ++
 t/t4217-log-limit.sh             |  1 +
 t/t5811-proto-disable-git.sh     |  2 ++
 t/t9004-example.sh               |  2 ++
 10 files changed, 74 insertions(+), 16 deletions(-)
-Peff
Next: Jeff King
Message 1 of 7 in “a few more leak fixes”
  1. 0/3 a few more leak fixesJeff King, Oct 5, 2023
  2. 1/3 decorate: add clear_decoration() functionJeff King, Oct 5, 2023
  3. 2/3 revision: clear decoration structs during release_revisions()Jeff King, Oct 5, 2023
  4. Junio C HamanoOct 5, 2023
  5. Jeff KingOct 6, 2023
  6. Junio C HamanoOct 6, 2023
  7. 3/3 daemon: free listen_addr before returningJeff King, Oct 5, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.