[PATCH] t4014: replace "test -f" with "test_path_is_file"
- From
Vinayak Dev <vinayakdev.sci@gmail.com>
- Date
- Oct 5, 2023, 08:17 UTC
- Message-ID
- <20231005081700.50473-1-vinayakdev.sci@gmail.com>
From: Vinayak Dev <vinayakdev.sci@gmail.com>
Many tests in the codebase use test -[e|f|d].. commands to check for various conditions. However, the test command upon failure simply exits with a non-zero exit code(usually 1). Therefore, replace instances of "test -f" from t/t4014-format-patch.sh with the function test_path_is_file() defined in t/test-lib-functions.sh that exits with a debugging-friendly diagnostic message upon failure.
Signed-off-by: Vinayak Dev <vinayakdev.sci@gmail.com> --- t/t4014-format-patch.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh index 0a4ab36c3a..5f7d0836d6 100755 --- a/t/t4014-format-patch.sh +++ b/t/t4014-format-patch.sh @@ -763,7 +763,7 @@ test_expect_success 'format-patch from a subdirectory (1)' ' false ;; esac && - test -f "$filename" + test_path_is_file "$filename" ' test_expect_success 'format-patch from a subdirectory (2)' ' @@ -782,7 +782,7 @@ test_expect_success 'format-patch from a subdirectory (2)' ' ;; esac && basename=$(expr "$filename" : ".*/\(.*\)") && - test -f "sub/$basename" + test_path_is_file "sub/$basename" ' test_expect_success 'format-patch from a subdirectory (3)' ' @@ -794,7 +794,7 @@ test_expect_success 'format-patch from a subdirectory (3)' ' git format-patch -1 -o "$TRASH_DIRECTORY" ) && basename=$(expr "$filename" : ".*/\(.*\)") && - test -f "$basename" + test_path_is_file "$basename" ' test_expect_success 'format-patch --in-reply-to' ' base-commit: d0e8084c65cbf949038ae4cc344ac2c2efd77415
-- 2.42.0