git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] grep: use OPT_INTEGER_F for --max-depth

From
Jeff King <peff@peff.net>
Date
Sep 5, 2023, 07:21 UTC
Message-ID
<20230905072122.GG199565@coredump.intra.peff.net>
In-Reply-To
<4d2eb736-4f34-18f8-2eb7-20e7f7b8c2f8@web.de>
On Sat, Sep 02, 2023 at 08:54:54PM +0200, René Scharfe wrote:
Show 8 quoted lines
> a91f453f64 (grep: Add --max-depth option., 2009-07-22) added the option
> --max-depth, defining it using a positional struct option initializer of
> type OPTION_INTEGER.  It also sets defval to 1 for some reason, but that
> value would only be used if the flag PARSE_OPT_OPTARG was given.
> 
> Use the macro OPT_INTEGER_F instead to standardize the definition and
> specify only the necessary values.  This also normalizes argh to N_("n")
> as a side-effect, which is OK.

This looks correct to me (and an improvement in readability). In general, I wonder how many of the results from:

  git grep '{ OPTION'

could be converted to use the macros and end up more readable. There are a number of OPTARG ones, which I guess can't use macros. Looks like there are a handful of others (mostly for OPT_HIDDEN).

-Peff
Previous: René ScharfeNext: René Scharfe
Message 2 of 7 in “grep: use OPT_INTEGER_F for --max-depth”
  1. grep: use OPT_INTEGER_F for --max-depthRené Scharfe, Sep 2, 2023
  2. Jeff KingSep 5, 2023
  3. René ScharfeSep 7, 2023
  4. Jeff KingSep 7, 2023
  5. René ScharfeSep 8, 2023
  6. René ScharfeSep 9, 2023
  7. Jeff KingSep 12, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.