[PATCH v2 10/10] parse-options: mark unused parameters in noop callback
- From
Jeff King <peff@peff.net>
- Date
- Aug 31, 2023, 21:22 UTC
- Message-ID
- <20230831212220.GJ949469@coredump.intra.peff.net>
- In-Reply-To
- <20230831211637.GA949188@coredump.intra.peff.net>
Unsurprisingly, the noop options callback doesn't bother to look at any of its parameters. Let's mark them so that -Wunused-parameter does not complain.
Another option would be to drop the callback and have parse-options itself recognize OPT_NOOP_NOARG. But that seems like extra work for no real benefit.
Signed-off-by: Jeff King <peff@peff.net> --- parse-options-cb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/parse-options-cb.c b/parse-options-cb.c index a24521dee0..bdc7fae497 100644 --- a/parse-options-cb.c +++ b/parse-options-cb.c @@ -227,7 +227,9 @@ int parse_opt_strvec(const struct option *opt, const char *arg, int unset) return 0; } -int parse_opt_noop_cb(const struct option *opt, const char *arg, int unset) +int parse_opt_noop_cb(const struct option *opt UNUSED, + const char *arg UNUSED, + int unset UNUSED) { return 0; }
-- 2.42.0.561.gaa987ecc69