Re: [PATCH] builtin/log.c: prepend "RFC" on --rfc

From: Jeff King <peff@peff.net>
Date: Aug 28, 2023, 17:42 UTC
Message-ID: <20230828174259.GA3007263@coredump.intra.peff.net>
In-Reply-To: <ae22b71b-73ea-4634-bd2a-4b64082be955@gmail.com>

On Mon, Aug 28, 2023 at 05:30:36PM +0100, Phillip Wood wrote:

Show 12 quoted lines

> I agree it sounds like a good change but if we're going to change it than I
> think we should ensure
> 
>     git format-patch --subject-prefix=foo --rfc
> 
> and
> 
>     git format-patch --rfc --subject-prefix=foo
> 
> give the same result. That would mean dropping rfc_callback() and using
> OPT_BOOL() instead of OPT_CALLBACK_F(). We could add the "RFC " prefix just
> before we add the re-roll suffix.

Good catch. That should also make the leak issue easier to solve, too, as we'd hold the string (and free it) in the main cmd_format_patch() function. This is exactly how the "reroll_count" feature works currently.

-Peff