[PATCH v2] builtin/log.c: prepend "RFC" on --rfc
- From
Drew DeVault <sir@cmpwn.com>
- Date
- Aug 28, 2023, 14:48 UTC
- Message-ID
- <20230828144940.18245-1-sir@cmpwn.com>
Rather than replacing the configured subject prefix (either through the git config or command line) entirely with "RFC PATCH", this change prepends RFC to whatever subject prefix was already in use.
This is useful, for example, when a user is working on a repository that has a subject prefix considered to disambiguate patches:
git config format.subjectPrefix 'PATCH my-project'
Prior to this change, formatting patches with --rfc would lose the 'my-project' information.
Signed-off-by: Drew DeVault <sir@cmpwn.com> --- v2 incorporates feedback from Jeff King regarding the lifetime of the heap-allocated "RFC %s" formatted string.
Documentation/git-format-patch.txt | 6 +++--- builtin/log.c | 12 +++++++++++- t/t4014-format-patch.sh | 9 +++++++++ 3 files changed, 23 insertions(+), 4 deletions(-)
diff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt index 373b46fc0d..fdc52cf826 100644 --- a/Documentation/git-format-patch.txt +++ b/Documentation/git-format-patch.txt @@ -229,9 +229,9 @@ populated with placeholder text. variable, or 64 if unconfigured. --rfc:: - Alias for `--subject-prefix="RFC PATCH"`. RFC means "Request For - Comments"; use this when sending an experimental patch for - discussion rather than application. + Prepends "RFC" to the subject prefix (producing "RFC PATCH" by + default). RFC means "Request For Comments"; use this when sending + an experimental patch for discussion rather than application. -v <n>:: --reroll-count=<n>:: diff --git a/builtin/log.c b/builtin/log.c index db3a88bfe9..854216ee9c 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -1476,9 +1476,19 @@ static int subject_prefix_callback(const struct option *opt, const char *arg, static int rfc_callback(const struct option *opt, const char *arg, int unset) { + /* + * The subject_prefix in rev_info is not heap-allocated except in this + * specific case, so there is no obvious place to free it. Since this + * value is retained for the lifetime of the process, we just + * statically allocate storage for it here. + */ + static char *prefix; BUG_ON_OPT_NEG(unset); BUG_ON_OPT_ARG(arg); - return subject_prefix_callback(opt, "RFC PATCH", unset); + + free(prefix); + prefix = xstrfmt("RFC %s", ((struct rev_info *)opt->value)->subject_prefix); + return subject_prefix_callback(opt, prefix, unset); } static int numbered_cmdline_opt = 0; diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh index 3cf2b7a7fb..a7fe839683 100755 --- a/t/t4014-format-patch.sh +++ b/t/t4014-format-patch.sh @@ -1377,6 +1377,15 @@ test_expect_success '--rfc' ' test_cmp expect actual ' +test_expect_success '--rfc does not overwrite prefix' ' + cat >expect <<-\EOF && + Subject: [RFC PATCH foobar 1/1] header with . in it + EOF + git format-patch -n -1 --stdout --subject-prefix "PATCH foobar" --rfc >patch && + grep ^Subject: patch >actual && + test_cmp expect actual +' + test_expect_success '--from=ident notices bogus ident' ' test_must_fail git format-patch -1 --stdout --from=foo >patch '
-- 2.42.0