Re: [PATCH 00/15] bloom: changed-path Bloom filters v2
- From
- Jonathan Tan <jonathantanmy@google.com>
- Date
- Aug 25, 2023, 17:06 UTC
- Message-ID
- <20230825170656.2598201-1-jonathantanmy@google.com>
- In-Reply-To
- <20230824222246.2320443-1-jonathantanmy@google.com>
Jonathan Tan <jonathantanmy@google.com> writes:
Show 22 quoted lines
> Taylor Blau <me@ttaylorr.com> writes: > > Jonathan Tan (4): > > gitformat-commit-graph: describe version 2 of BDAT > > t4216: test changed path filters with high bit paths > > repo-settings: introduce commitgraph.changedPathsVersion > > commit-graph: new filter ver. that fixes murmur3 > > > > Taylor Blau (11): > > t/helper/test-read-graph.c: extract `dump_graph_info()` > > bloom.h: make `load_bloom_filter_from_graph()` public > > t/helper/test-read-graph: implement `bloom-filters` mode > > bloom: annotate filters with hash version > > bloom: prepare to discard incompatible Bloom filters > > t/t4216-log-bloom.sh: harden `test_bloom_filters_not_used()` > > commit-graph.c: unconditionally load Bloom filters > > commit-graph: drop unnecessary `graph_read_bloom_data_context` > > object.h: fix mis-aligned flag bits table > > commit-graph: reuse existing Bloom filters where possible > > bloom: introduce `deinit_bloom_filters()` > > Thanks. I had one small comment (sent as an email reply to one of the > patches), but everything else looks good.
I mistakenly sent my reply to an earlier version [1]. (Taylor has seen it, so this note is more for future readers who might be curious about what that email reply contains.)
[1] https://lore.kernel.org/git/20230824222051.2320003-1-jonathantanmy@google.com/